[PR #43] [MERGED] Fixes issue where sentences containing strong emphasis words did not correctly delimit the strong tag #778

Open
opened 2026-01-29 14:45:24 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/xoofx/markdig/pull/43
Author: @christophano
Created: 7/28/2016
Status: Merged
Merged: 7/30/2016
Merged by: @xoofx

Base: masterHead: bugfix/strong-emphasis


📝 Commits (1)

  • 891c80f Fixes issue where sentences containing strong emphasis words did not correctly delimit the strong tag

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 src/Markdig/Parsers/Inlines/EmphasisInlineParser.cs (+2 -1)

📄 Description

Scenario:

***Strong emphasis*** normal

Should result in:

<p><strong><em>Strong emphasis</em></strong> normal</p>

But actually outputs:

<p><strong><em>Strong emphasis</em> normal</strong></p>

Note: I haven't included a spec to demonstrate the fix, as the specs for this part comes from CommonMark. Would you prefer me to add a new spec to this pull request, or to submit a pull request to the CommonMark spec?


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/xoofx/markdig/pull/43 **Author:** [@christophano](https://github.com/christophano) **Created:** 7/28/2016 **Status:** ✅ Merged **Merged:** 7/30/2016 **Merged by:** [@xoofx](https://github.com/xoofx) **Base:** `master` ← **Head:** `bugfix/strong-emphasis` --- ### 📝 Commits (1) - [`891c80f`](https://github.com/xoofx/markdig/commit/891c80f48c0d7caa9c9454df080310ca242e19f3) Fixes issue where sentences containing strong emphasis words did not correctly delimit the strong tag ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Markdig/Parsers/Inlines/EmphasisInlineParser.cs` (+2 -1) </details> ### 📄 Description Scenario: ``` ***Strong emphasis*** normal ``` Should result in: ``` <p><strong><em>Strong emphasis</em></strong> normal</p> ``` But actually outputs: ``` <p><strong><em>Strong emphasis</em> normal</strong></p> ``` **Note:** I haven't included a spec to demonstrate the fix, as the specs for this part comes from CommonMark. Would you prefer me to add a new spec to this pull request, or to submit a pull request to the CommonMark spec? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 14:45:24 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#778