starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-03 21:36:36 +00:00
Code Issues 690 Packages Projects Releases 20 Wiki Activity

[PR #45] [MERGED] Adds support for rowspans in grid tables #779

New Issue
Open
opened 2026-01-29 14:45:24 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 14:45:24 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/xoofx/markdig/pull/45
Author: @christophano
Created: 8/12/2016
Status: ✅ Merged
Merged: 9/15/2016
Merged by: @xoofx

Base: master ← Head: feature/rowspan

📝 Commits (2)

  • 9506f22 Adds support for rowspans in grid tables
  • a3691c4 Fixed issue when malformed tables can result in an unhandled exception being thrown.

📊 Changes

6 files changed (+509 additions, -232 deletions)

View changed files

📝 src/Markdig.Tests/Specs/GridTableSpecs.md (+89 -0)
📝 src/Markdig.Tests/Specs/Specs.cs (+125 -0)
📝 src/Markdig/Extensions/Tables/GridTableParser.cs (+241 -229)
📝 src/Markdig/Extensions/Tables/HtmlTableRenderer.cs (+7 -3)
📝 src/Markdig/Extensions/Tables/Table.cs (+35 -0)
📝 src/Markdig/Extensions/Tables/TableCell.cs (+12 -0)

📄 Description

I'm afraid I changed the Grid Table Parser quite a bit here.
Feel free to wrap my knuckles and suggest better changes though!

This adds support for cells spanning rows, in addition to columns.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/xoofx/markdig/pull/45 **Author:** [@christophano](https://github.com/christophano) **Created:** 8/12/2016 **Status:** ✅ Merged **Merged:** 9/15/2016 **Merged by:** [@xoofx](https://github.com/xoofx) **Base:** `master` ← **Head:** `feature/rowspan` --- ### 📝 Commits (2) - [`9506f22`](https://github.com/xoofx/markdig/commit/9506f2202564732309a9111e61579811d0205c44) Adds support for rowspans in grid tables - [`a3691c4`](https://github.com/xoofx/markdig/commit/a3691c4423e746eb02354a97ee029906a6432283) Fixed issue when malformed tables can result in an unhandled exception being thrown. ### 📊 Changes **6 files changed** (+509 additions, -232 deletions) <details> <summary>View changed files</summary> 📝 `src/Markdig.Tests/Specs/GridTableSpecs.md` (+89 -0) 📝 `src/Markdig.Tests/Specs/Specs.cs` (+125 -0) 📝 `src/Markdig/Extensions/Tables/GridTableParser.cs` (+241 -229) 📝 `src/Markdig/Extensions/Tables/HtmlTableRenderer.cs` (+7 -3) 📝 `src/Markdig/Extensions/Tables/Table.cs` (+35 -0) 📝 `src/Markdig/Extensions/Tables/TableCell.cs` (+12 -0) </details> ### 📄 Description I'm afraid I changed the `Grid Table Parser` quite a bit here. Feel free to wrap my knuckles and suggest better changes though! This adds support for cells spanning rows, in addition to columns. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 14:45:24 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
extension
Hacktoberfest
invalid
PR Welcome!
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#779
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?