starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-12 21:39:32 +00:00
Code Issues 690 Packages Projects Releases 21 Wiki Activity

[PR #81] [MERGED] Use Char.ToUpperInvariant instead of Char.ToUpper #804

New Issue
Open
opened 2026-01-29 14:45:46 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 14:45:46 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/xoofx/markdig/pull/81
Author: @volkanceylan
Created: 12/18/2016
Status: ✅ Merged
Merged: 12/18/2016
Merged by: @xoofx

Base: master ← Head: master

📝 Commits (1)

  • 013ec0b Due to use of Char.ToUpper, ListExtraItemParser fails in cultures like Turkish where uppercase of 'i' is 'İ'. Char.ToUpperInvariant should be used instead.

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 src/Markdig/Extensions/ListExtras/ListExtraItemParser.cs (+1 -1)
📝 src/Markdig/Helpers/CharHelper.cs (+2 -2)

📄 Description

Due to use of Char.ToUpper, ListExtraItemParser fails in cultures like Turkish where uppercase of 'i' is 'İ'. Char.ToUpperInvariant should be used instead.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/xoofx/markdig/pull/81 **Author:** [@volkanceylan](https://github.com/volkanceylan) **Created:** 12/18/2016 **Status:** ✅ Merged **Merged:** 12/18/2016 **Merged by:** [@xoofx](https://github.com/xoofx) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`013ec0b`](https://github.com/xoofx/markdig/commit/013ec0bf802af7aed4016e34d1d51a8397856cf7) Due to use of Char.ToUpper, ListExtraItemParser fails in cultures like Turkish where uppercase of 'i' is 'İ'. Char.ToUpperInvariant should be used instead. ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/Markdig/Extensions/ListExtras/ListExtraItemParser.cs` (+1 -1) 📝 `src/Markdig/Helpers/CharHelper.cs` (+2 -2) </details> ### 📄 Description Due to use of Char.ToUpper, ListExtraItemParser fails in cultures like Turkish where uppercase of 'i' is 'İ'. Char.ToUpperInvariant should be used instead. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 14:45:46 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
extension
Hacktoberfest
invalid
PR Welcome!
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#804
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?