[PR #82] [MERGED] Fixes the IsValidAbbreviation method in AbbreviationParser #805

New Issue

claunia · 2026-01-29T14:45:46Z

claunia commented

2026-01-29 14:45:46 +00:00

📋 Pull Request Information

Original PR: https://github.com/xoofx/markdig/pull/82
Author: @christophano
Created: 12/19/2016
Status: ✅ Merged
Merged: 12/19/2016
Merged by: @xoofx

Base: master ← Head: bugfix/abbreviation_parser_fix

📝 Commits (2)

2d0dae4 Fixes the IsValidAbbreviation method in AbbreviationParser
ba4e463 Adds the test I ought to have included to begin with.

📊 Changes

3 files changed (+34 additions, -2 deletions)

View changed files

📝 src/Markdig.Tests/Specs/AbbreviationSpecs.md (+10 -0)
📝 src/Markdig.Tests/Specs/Specs.cs (+22 -0)
📝 src/Markdig/Extensions/Abbreviations/AbbreviationParser.cs (+2 -2)

📄 Description

I made a schoolboy error in my previous fix for the abbreviation parser.
It works perfectly well for most cases, but has issues where an almost valid abbreviation is the first, last or only value in the correct content block.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/xoofx/markdig/pull/82 **Author:** [@christophano](https://github.com/christophano) **Created:** 12/19/2016 **Status:** ✅ Merged **Merged:** 12/19/2016 **Merged by:** [@xoofx](https://github.com/xoofx) **Base:** `master` ← **Head:** `bugfix/abbreviation_parser_fix` --- ### 📝 Commits (2) - [`2d0dae4`](https://github.com/xoofx/markdig/commit/2d0dae4ebb5a0f54194fe9f520b27a5add644ea9) Fixes the IsValidAbbreviation method in AbbreviationParser - [`ba4e463`](https://github.com/xoofx/markdig/commit/ba4e463517fdfce994fdf49b3817a89fcc69a135) Adds the test I ought to have included to begin with. ### 📊 Changes **3 files changed** (+34 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/Markdig.Tests/Specs/AbbreviationSpecs.md` (+10 -0) 📝 `src/Markdig.Tests/Specs/Specs.cs` (+22 -0) 📝 `src/Markdig/Extensions/Abbreviations/AbbreviationParser.cs` (+2 -2) </details> ### 📄 Description I made a schoolboy error in my previous fix for the abbreviation parser. It works perfectly well for _most_ cases, but has issues where an _almost_ valid abbreviation is the first, last or only value in the correct content block. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 14:45:46 +00:00

claunia closed this issue

2026-01-29 14:45:48 +00:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/markdig#805