starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-03 21:36:36 +00:00
Code Issues 690 Packages Projects Releases 20 Wiki Activity

[PR #116] [CLOSED] Some condition fixes. Issue #115 #814

New Issue
Open
opened 2026-01-29 14:45:54 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 14:45:54 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/xoofx/markdig/pull/116
Author: @Backs
Created: 5/24/2017
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (4)

  • eaffb88 #115 - fixcondition. before fix it's always false
  • 1c39991 #115 - remove always true expression. endState changes from 0 to 1 only and does it on first iteration
  • cdc5423 #115 - remove unesed variable
  • 704f791 #115 - remove check, because it's always false. NewBlocks.Count can not be more than 0, because before we checked for NewBlocks.Count == 0

📊 Changes

4 files changed (+22 additions, -36 deletions)

View changed files

📝 src/Markdig/Helpers/HtmlHelper.cs (+7 -7)
📝 src/Markdig/Helpers/LinkHelper.cs (+0 -5)
📝 src/Markdig/Parsers/BlockProcessor.cs (+0 -6)
📝 src/Markdig/Parsers/HeadingBlockParser.cs (+15 -18)

📄 Description

I fixed some obvious errors, that were found by PVS

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/xoofx/markdig/pull/116 **Author:** [@Backs](https://github.com/Backs) **Created:** 5/24/2017 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`eaffb88`](https://github.com/xoofx/markdig/commit/eaffb884b4ae77fc181c56fd260cdb805fcf3187) #115 - fixcondition. before fix it's always false - [`1c39991`](https://github.com/xoofx/markdig/commit/1c3999165bfc3d0c70c9121bbb4725e81a5d8ae2) #115 - remove always true expression. endState changes from 0 to 1 only and does it on first iteration - [`cdc5423`](https://github.com/xoofx/markdig/commit/cdc5423bcaee216d479175a809c4f637c92c173e) #115 - remove unesed variable - [`704f791`](https://github.com/xoofx/markdig/commit/704f791675163c964bba2f1f91d9712ab59ae645) #115 - remove check, because it's always false. NewBlocks.Count can not be more than 0, because before we checked for NewBlocks.Count == 0 ### 📊 Changes **4 files changed** (+22 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `src/Markdig/Helpers/HtmlHelper.cs` (+7 -7) 📝 `src/Markdig/Helpers/LinkHelper.cs` (+0 -5) 📝 `src/Markdig/Parsers/BlockProcessor.cs` (+0 -6) 📝 `src/Markdig/Parsers/HeadingBlockParser.cs` (+15 -18) </details> ### 📄 Description I fixed some obvious errors, that were found by PVS --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 14:45:54 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
extension
Hacktoberfest
invalid
PR Welcome!
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#814
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?