[PR #147] [CLOSED] media extension template and some refactoring #832

New Issue

claunia · 2026-01-29T14:46:08Z

claunia commented

2026-01-29 14:46:08 +00:00

📋 Pull Request Information

Original PR: https://github.com/xoofx/markdig/pull/147
Author: @MaddalenaTech
Created: 9/28/2017
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (10+)

77d6f42 added iframe template option (making compatible with things like bootstrap responsive embedded)
18b2e1d refactoring
845b306 removed unused assignments
a428948 redundant empty constructors
4b30caa use null propagation
dc9db1b empty stataments
bd164d2 unused variable
586e3f6 unused method
5b98604 auto property can be made get-only
5828e10 never used parameter

📊 Changes

40 files changed (+132 additions, -181 deletions)

View changed files

➕ src/Markdig.Benchmarks/Markdig.Benchmarks.nuget.targets (+18 -0)
📝 src/Markdig.Benchmarks/Program.cs (+2 -2)
📝 src/Markdig.Benchmarks/TestStringPerf.cs (+1 -1)
📝 src/Markdig/Extensions/Footnotes/Footnote.cs (+1 -1)
📝 src/Markdig/Extensions/GenericAttributes/GenericAttributesParser.cs (+3 -3)
📝 src/Markdig/Extensions/Mathematics/MathBlockParser.cs (+1 -1)
📝 src/Markdig/Extensions/Mathematics/MathInlineParser.cs (+2 -2)
📝 src/Markdig/Extensions/MediaLinks/MediaLinkExtension.cs (+32 -31)
📝 src/Markdig/Extensions/MediaLinks/MediaOptions.cs (+3 -1)
📝 src/Markdig/Extensions/SmartyPants/HtmlSmartyPantRenderer.cs (+1 -2)
📝 src/Markdig/Extensions/Tables/PipeTableParser.cs (+2 -3)
📝 src/Markdig/Extensions/Tables/Table.cs (+4 -4)
📝 src/Markdig/Extensions/Yaml/YamlFrontMatterParser.cs (+3 -3)
📝 src/Markdig/Helpers/CharHelper.cs (+1 -1)
📝 src/Markdig/Helpers/LineReader.cs (+1 -2)
📝 src/Markdig/Helpers/StringLineGroup.cs (+1 -1)
📝 src/Markdig/Helpers/StringSlice.cs (+3 -4)
📝 src/Markdig/Helpers/TextMatcher.cs (+2 -4)
📝 src/Markdig/MarkdownPipeline.cs (+2 -4)
📝 src/Markdig/MarkdownPipelineBuilder.cs (+2 -2)

...and 20 more files

📄 Description

Allowing to put a template as iframe instead of just choosing heigth and width.
This allow compatibility with frameworks like bootstrap 4.

http://getbootstrap.com/docs/4.0/utilities/embed/

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/xoofx/markdig/pull/147 **Author:** [@MaddalenaTech](https://github.com/MaddalenaTech) **Created:** 9/28/2017 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`77d6f42`](https://github.com/xoofx/markdig/commit/77d6f42f2ddccd068d182a407cff9f24b87e1c44) added iframe template option (making compatible with things like bootstrap responsive embedded) - [`18b2e1d`](https://github.com/xoofx/markdig/commit/18b2e1d00410063f357f8c2ff487e726a04ae935) refactoring - [`845b306`](https://github.com/xoofx/markdig/commit/845b30634b53ddedde8c6e3a3a7d7bc8eed58a6d) removed unused assignments - [`a428948`](https://github.com/xoofx/markdig/commit/a4289482b6d4ae488428dab6eb0d06fc876f3655) redundant empty constructors - [`4b30caa`](https://github.com/xoofx/markdig/commit/4b30caac90a3f019975afbde6181663a86b46249) use null propagation - [`dc9db1b`](https://github.com/xoofx/markdig/commit/dc9db1b5919b11418e7a3df8142479790b6f89b7) empty stataments - [`bd164d2`](https://github.com/xoofx/markdig/commit/bd164d25bc4f3be6fdd6b278301625ff65c9ffc6) unused variable - [`586e3f6`](https://github.com/xoofx/markdig/commit/586e3f6ac73fd7046bf5a33158a868ed6ca4daee) unused method - [`5b98604`](https://github.com/xoofx/markdig/commit/5b98604b7d3745c623a875db276dffdc37a1a36e) auto property can be made get-only - [`5828e10`](https://github.com/xoofx/markdig/commit/5828e103d2b9da907b303e51b4060d872048e138) never used parameter ### 📊 Changes **40 files changed** (+132 additions, -181 deletions) <details> <summary>View changed files</summary> ➕ `src/Markdig.Benchmarks/Markdig.Benchmarks.nuget.targets` (+18 -0) 📝 `src/Markdig.Benchmarks/Program.cs` (+2 -2) 📝 `src/Markdig.Benchmarks/TestStringPerf.cs` (+1 -1) 📝 `src/Markdig/Extensions/Footnotes/Footnote.cs` (+1 -1) 📝 `src/Markdig/Extensions/GenericAttributes/GenericAttributesParser.cs` (+3 -3) 📝 `src/Markdig/Extensions/Mathematics/MathBlockParser.cs` (+1 -1) 📝 `src/Markdig/Extensions/Mathematics/MathInlineParser.cs` (+2 -2) 📝 `src/Markdig/Extensions/MediaLinks/MediaLinkExtension.cs` (+32 -31) 📝 `src/Markdig/Extensions/MediaLinks/MediaOptions.cs` (+3 -1) 📝 `src/Markdig/Extensions/SmartyPants/HtmlSmartyPantRenderer.cs` (+1 -2) 📝 `src/Markdig/Extensions/Tables/PipeTableParser.cs` (+2 -3) 📝 `src/Markdig/Extensions/Tables/Table.cs` (+4 -4) 📝 `src/Markdig/Extensions/Yaml/YamlFrontMatterParser.cs` (+3 -3) 📝 `src/Markdig/Helpers/CharHelper.cs` (+1 -1) 📝 `src/Markdig/Helpers/LineReader.cs` (+1 -2) 📝 `src/Markdig/Helpers/StringLineGroup.cs` (+1 -1) 📝 `src/Markdig/Helpers/StringSlice.cs` (+3 -4) 📝 `src/Markdig/Helpers/TextMatcher.cs` (+2 -4) 📝 `src/Markdig/MarkdownPipeline.cs` (+2 -4) 📝 `src/Markdig/MarkdownPipelineBuilder.cs` (+2 -2) _...and 20 more files_ </details> ### 📄 Description Allowing to put a template as iframe instead of just choosing heigth and width. This allow compatibility with frameworks like bootstrap 4. http://getbootstrap.com/docs/4.0/utilities/embed/ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 14:46:08 +00:00

claunia closed this issue

2026-01-29 14:46:10 +00:00

claunia referenced this issue

2026-01-29 14:51:51 +00:00

[PR #832] [MERGED] Set the correct source location in Footnote and FootnoteLinkReferenceDefinition #1239

Sign in to join this conversation.