starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-10 05:49:27 +00:00
Code Issues 690 Packages Projects Releases 20 Wiki Activity

[PR #239] [MERGED] Globalization Extension #885

New Issue
Open
opened 2026-01-29 14:46:49 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 14:46:49 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/xoofx/markdig/pull/239
Author: @mhmd-azeez
Created: 8/25/2018
Status: ✅ Merged
Merged: 8/28/2018
Merged by: @xoofx

Base: master ← Head: master

📝 Commits (9)

  • 5aa1384 add globalization extension
  • d05bc15 only take strong characters into consideration when deciding whether a block should be rtl or not
  • 7292acc make sure TaskList's X doesn't affect whether a block is marked as RTL or not
  • fc5d832 Add globalization case for Configure extension method
  • 16c0829 add globalization spec
  • 8767a1d take surrogate characters into account
  • 7d7598d fix copyright notices
  • a99b7f4 update globalization specs, docs and tests
  • dfcd5cd Fix the specs to make sure that the requried extensions are added in the tests

📊 Changes

7 files changed (+997 additions, -2 deletions)

View changed files

📝 src/Markdig.Tests/Markdig.Tests.csproj (+1 -0)
➕ src/Markdig.Tests/Specs/GlobalizationSpecs.md (+189 -0)
📝 src/Markdig.Tests/Specs/Specs.cs (+229 -1)
📝 src/Markdig.Tests/Specs/Specs.tt (+1 -0)
➕ src/Markdig/Extensions/Globalization/GlobalizationExtension.cs (+108 -0)
📝 src/Markdig/Helpers/CharHelper.cs (+454 -1)
📝 src/Markdig/MarkdownExtensions.cs (+15 -0)

📄 Description

Closes #238

This extension adds dir="rtl" attribute to elements that start with RTL characters, RTL characters are specified by section D of RFC3454.

The main work on the extension done, what remains is for me to test it a bit more, possibly make it more efficient and less verbose and write a couple of unit tests and documentation.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/xoofx/markdig/pull/239 **Author:** [@mhmd-azeez](https://github.com/mhmd-azeez) **Created:** 8/25/2018 **Status:** ✅ Merged **Merged:** 8/28/2018 **Merged by:** [@xoofx](https://github.com/xoofx) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (9) - [`5aa1384`](https://github.com/xoofx/markdig/commit/5aa138425f45bed99347333ce391dc7f78523eb3) add globalization extension - [`d05bc15`](https://github.com/xoofx/markdig/commit/d05bc1572dcdb78c6ce467c1143170bf7b20ef03) only take strong characters into consideration when deciding whether a block should be rtl or not - [`7292acc`](https://github.com/xoofx/markdig/commit/7292acc27a4d1c9de85cf752f36abc267f5bb806) make sure TaskList's X doesn't affect whether a block is marked as RTL or not - [`fc5d832`](https://github.com/xoofx/markdig/commit/fc5d8324329a9ff088e65123c888c62e7c9b72de) Add globalization case for Configure extension method - [`16c0829`](https://github.com/xoofx/markdig/commit/16c0829d9ea9705ff5cb941d67dd95e11f1c8f01) add globalization spec - [`8767a1d`](https://github.com/xoofx/markdig/commit/8767a1d8edd700985fa201de54217d5c9fc101ed) take surrogate characters into account - [`7d7598d`](https://github.com/xoofx/markdig/commit/7d7598db5496f02618504076856e1374e0bba661) fix copyright notices - [`a99b7f4`](https://github.com/xoofx/markdig/commit/a99b7f4572d5479cba01262c76e72e441685c192) update globalization specs, docs and tests - [`dfcd5cd`](https://github.com/xoofx/markdig/commit/dfcd5cddfa3ea6099ed82200ca6ddcd287dcf818) Fix the specs to make sure that the requried extensions are added in the tests ### 📊 Changes **7 files changed** (+997 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/Markdig.Tests/Markdig.Tests.csproj` (+1 -0) ➕ `src/Markdig.Tests/Specs/GlobalizationSpecs.md` (+189 -0) 📝 `src/Markdig.Tests/Specs/Specs.cs` (+229 -1) 📝 `src/Markdig.Tests/Specs/Specs.tt` (+1 -0) ➕ `src/Markdig/Extensions/Globalization/GlobalizationExtension.cs` (+108 -0) 📝 `src/Markdig/Helpers/CharHelper.cs` (+454 -1) 📝 `src/Markdig/MarkdownExtensions.cs` (+15 -0) </details> ### 📄 Description Closes #238 This extension adds dir="rtl" attribute to elements that start with RTL characters, RTL characters are specified by section D of [RFC3454](http://www.ietf.org/rfc/rfc3454.txt). The main work on the extension done, what remains is for me to test it a bit more, possibly make it more efficient and less verbose and write a couple of unit tests and documentation. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 14:46:50 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
extension
Hacktoberfest
invalid
PR Welcome!
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#885
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?