starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-14 05:45:05 +00:00
Code Issues 690 Packages Projects Releases 21 Wiki Activity

[PR #319] [MERGED] Allow unicode domain names #942

New Issue
Open
opened 2026-01-29 14:47:37 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 14:47:37 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/xoofx/markdig/pull/319
Author: @MihaZupan
Created: 3/11/2019
Status: ✅ Merged
Merged: 3/11/2019
Merged by: @xoofx

Base: master ← Head: allow-unicode-domain-names

📝 Commits (8)

  • 3b3872f Use a universal time format for spec timestamps
  • 04e195c Add tests for unicode in domain names
  • 47f395d Add unicode domain name test for LinkReferenceDefinitions
  • 39ab066 Exclude nuget.props from source control
  • db9660d Allow non-ascii characters in domain names
  • 1c88fb6 Use IDNA encoding for domain names containing non-ascii chars
  • 77d5dcb Drop support for netstandard1.1 and legacy PCL
  • 50313a3 Update changelog

📊 Changes

10 files changed (+287 additions, -41 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 changelog.md (+3 -0)
📝 src/Markdig.Tests/Specs/AutoLinks.cs (+110 -1)
📝 src/Markdig.Tests/Specs/AutoLinks.md (+59 -0)
📝 src/Markdig.Tests/TestLinkHelper.cs (+6 -0)
📝 src/Markdig/Helpers/CharHelper.cs (+27 -4)
📝 src/Markdig/Helpers/LinkHelper.cs (+17 -11)
📝 src/Markdig/Markdig.csproj (+2 -13)
📝 src/Markdig/Renderers/HtmlRenderer.cs (+61 -11)
📝 src/SpecFileGen/Program.cs (+1 -1)

📄 Description

Fixes #316

IDNA encoding is not used on standard1.1 and portable as explained here.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/xoofx/markdig/pull/319 **Author:** [@MihaZupan](https://github.com/MihaZupan) **Created:** 3/11/2019 **Status:** ✅ Merged **Merged:** 3/11/2019 **Merged by:** [@xoofx](https://github.com/xoofx) **Base:** `master` ← **Head:** `allow-unicode-domain-names` --- ### 📝 Commits (8) - [`3b3872f`](https://github.com/xoofx/markdig/commit/3b3872ffe387382916a5ea74a56406ac89882539) Use a universal time format for spec timestamps - [`04e195c`](https://github.com/xoofx/markdig/commit/04e195cdb279aa9af9d65d929c50aadfa2587c11) Add tests for unicode in domain names - [`47f395d`](https://github.com/xoofx/markdig/commit/47f395dad7b5cb6573a402f5ff5710990a30c863) Add unicode domain name test for LinkReferenceDefinitions - [`39ab066`](https://github.com/xoofx/markdig/commit/39ab066e2dcd0ca68d8cc1d87bce1830bfb2783d) Exclude nuget.props from source control - [`db9660d`](https://github.com/xoofx/markdig/commit/db9660d090082f6b53cf37edbffd722825610883) Allow non-ascii characters in domain names - [`1c88fb6`](https://github.com/xoofx/markdig/commit/1c88fb65c86988e29448b23c44e54151275ed5bb) Use IDNA encoding for domain names containing non-ascii chars - [`77d5dcb`](https://github.com/xoofx/markdig/commit/77d5dcb6dd0c652d67afcfc09e56f58941cc31b8) Drop support for netstandard1.1 and legacy PCL - [`50313a3`](https://github.com/xoofx/markdig/commit/50313a36dcab722c9e2d262177984e2f3d774695) Update changelog ### 📊 Changes **10 files changed** (+287 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `changelog.md` (+3 -0) 📝 `src/Markdig.Tests/Specs/AutoLinks.cs` (+110 -1) 📝 `src/Markdig.Tests/Specs/AutoLinks.md` (+59 -0) 📝 `src/Markdig.Tests/TestLinkHelper.cs` (+6 -0) 📝 `src/Markdig/Helpers/CharHelper.cs` (+27 -4) 📝 `src/Markdig/Helpers/LinkHelper.cs` (+17 -11) 📝 `src/Markdig/Markdig.csproj` (+2 -13) 📝 `src/Markdig/Renderers/HtmlRenderer.cs` (+61 -11) 📝 `src/SpecFileGen/Program.cs` (+1 -1) </details> ### 📄 Description Fixes #316 [`IDNA encoding`](https://en.wikipedia.org/wiki/Internationalized_domain_name#Example_of_IDNA_encoding) is not used on `standard1.1` and `portable` as [explained here](https://github.com/lunet-io/markdig/issues/316#issuecomment-471211325). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 14:47:37 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
extension
Hacktoberfest
invalid
PR Welcome!
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#942
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?