[PR #359] [CLOSED] [WIP] Optimize abbreviation parser re-entry #969

Open
opened 2026-01-29 14:47:56 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/xoofx/markdig/pull/359
Author: @MihaZupan
Created: 7/28/2019
Status: Closed

Base: masterHead: master


📝 Commits (3)

📊 Changes

7 files changed (+59 additions, -5 deletions)

View changed files

📝 src/Markdig.Tests/IssuesMarkdown/275.md (+0 -0)
📝 src/Markdig.Tests/IssuesMarkdown/278.md (+0 -0)
src/Markdig.Tests/IssuesMarkdown/306.md (+5 -0)
📝 src/Markdig.Tests/MiscTests.cs (+15 -2)
📝 src/Markdig.Tests/TestParser.cs (+7 -0)
📝 src/Markdig/Extensions/Abbreviations/AbbreviationParser.cs (+25 -3)
src/Markdig/Helpers/RefInt.cs (+7 -0)

📄 Description

This improves performance in cases like #306 where the AbbreviationParser's PostMatch was running over the entire LiteralInline, every time a new character was appended to it. Now it only checks the ending.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/xoofx/markdig/pull/359 **Author:** [@MihaZupan](https://github.com/MihaZupan) **Created:** 7/28/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`c8e105c`](https://github.com/xoofx/markdig/commit/c8e105c9e4f5f62f8b499e686bd5ac713fc65737) Add test for Issue #306 - [`213b811`](https://github.com/xoofx/markdig/commit/213b8114429abaad5a894b7be99d5e1a00504135) Optimize abbreviation parser re-entry - [`62a8d4f`](https://github.com/xoofx/markdig/commit/62a8d4f3181fe0a9d290852f3c9b036946df8ede) Allow more timing leeway during CI ### 📊 Changes **7 files changed** (+59 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/Markdig.Tests/IssuesMarkdown/275.md` (+0 -0) 📝 `src/Markdig.Tests/IssuesMarkdown/278.md` (+0 -0) ➕ `src/Markdig.Tests/IssuesMarkdown/306.md` (+5 -0) 📝 `src/Markdig.Tests/MiscTests.cs` (+15 -2) 📝 `src/Markdig.Tests/TestParser.cs` (+7 -0) 📝 `src/Markdig/Extensions/Abbreviations/AbbreviationParser.cs` (+25 -3) ➕ `src/Markdig/Helpers/RefInt.cs` (+7 -0) </details> ### 📄 Description This improves performance in cases like #306 where the AbbreviationParser's PostMatch was running over the entire LiteralInline, every time a new character was appended to it. Now it only checks the ending. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 14:47:56 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#969