starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-03 21:36:36 +00:00
Code Issues 690 Packages Projects Releases 20 Wiki Activity

[PR #388] [CLOSED] Optimized LineReader using string.IndexOfAny #979

New Issue
Open
opened 2026-01-29 14:48:06 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 14:48:06 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/xoofx/markdig/pull/388
Author: @KrisVandermotten
Created: 1/21/2020
Status: ❌ Closed

Base: master ← Head: linereader

📝 Commits (1)

  • 111d6fd Optimized LineReader using string.IndexOfAny

📊 Changes

1 file changed (+20 additions, -21 deletions)

View changed files

📝 src/Markdig/Helpers/LineReader.cs (+20 -21)

📄 Description

The LineReader struct is responsible for parsing source text into lines.

Given that String.IndexOfAny is now vectorized, it makes sense to use it instead of the handwritten, unoptimized loop in LineReader.ReadLine().

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/xoofx/markdig/pull/388 **Author:** [@KrisVandermotten](https://github.com/KrisVandermotten) **Created:** 1/21/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `linereader` --- ### 📝 Commits (1) - [`111d6fd`](https://github.com/xoofx/markdig/commit/111d6fd991065f8f7c26ffb9329641d07350a7a1) Optimized LineReader using string.IndexOfAny ### 📊 Changes **1 file changed** (+20 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `src/Markdig/Helpers/LineReader.cs` (+20 -21) </details> ### 📄 Description The `LineReader` struct is responsible for parsing source text into lines. Given that `String.IndexOfAny` [is now vectorized](https://source.dot.net/#System.Private.CoreLib/String.Searching.cs,cf166f50515b56ae), it makes sense to use it instead of the handwritten, unoptimized loop in `LineReader.ReadLine()`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 14:48:06 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
extension
Hacktoberfest
invalid
PR Welcome!
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#979
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?