From 23af8ed3c4633f965bc47c6a84971301a07a8d55 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Date: Mon, 11 May 2026 10:38:58 +0100 Subject: [PATCH] scripts: strip leading './' when searching MAINTAINERS file MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The following two uses of get_maintainer.pl should return the same results, but do not: $ ./scripts/get_maintainer.pl -f ./hw/net/vmxnet3.c get_maintainer.pl: No maintainers found, printing recent contributors. get_maintainer.pl: Do not blindly cc: them on patches! Use common sense. "Philippe Mathieu-Daudé" (commit_signer:4/7=57%) "Michael S. Tsirkin" (commit_signer:4/7=57%) Xiaoyao Li (commit_signer:3/7=43%) Thomas Huth (commit_signer:3/7=43%) Zhao Liu (commit_signer:3/7=43%) qemu-devel@nongnu.org (open list:All patches CC here) $ ./scripts/get_maintainer.pl -f hw/net/vmxnet3.c Dmitry Fleytman (maintainer:VMware) Jason Wang (odd fixer:Network devices) qemu-devel@nongnu.org (open list:All patches CC here) In the former case, the leading "./" needs to be removed before trying to find a filename match. Blindly stripping the "./" is valid because the script already enforces that it is run from the QEMU git root directory, so canonicalizing the filename vs $CWD is not required. Signed-off-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20260511093858.82753-1-berrange@redhat.com> Signed-off-by: Philippe Mathieu-Daudé --- scripts/get_maintainer.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 00a0870b26..76be402e11 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -384,6 +384,7 @@ foreach my $file (@ARGV) { } elsif (!(stat $file)) { die "$P: file '${file}' not found: $!\n"; } + $file =~ s,^./,,; } if ($from_filename) { push(@files, $file);