mirror of
https://github.com/qemu/qemu.git
synced 2026-02-04 02:24:51 +00:00
03a680c978
Make the synchronous calls evident by not hiding the call to migration_channel_connect_outgoing() in the transport code. Have those functions return and call the function at the upper level. This helps with navigation: the transport code returns the ioc, there's no need to look into them when browsing the code. It also allows RDMA in the source side to use the same path as the rest of the transports. While here, document the async calls which are the exception. Reviewed-by: Peter Xu <peterx@redhat.com> Reviewed-by: Prasad Pandit <pjp@fedoraproject.org> Link: https://lore.kernel.org/qemu-devel/20260123141656.6765-26-farosas@suse.de Signed-off-by: Fabiano Rosas <farosas@suse.de>
89 lines
2.7 KiB
C
89 lines
2.7 KiB
C
/*
|
|
* QEMU live migration
|
|
*
|
|
* Copyright IBM, Corp. 2008
|
|
* Copyright Dell MessageOne 2008
|
|
* Copyright Red Hat, Inc. 2015-2016
|
|
*
|
|
* Authors:
|
|
* Anthony Liguori <aliguori@us.ibm.com>
|
|
* Charles Duffy <charles_duffy@messageone.com>
|
|
* Daniel P. Berrange <berrange@redhat.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2. See
|
|
* the COPYING file in the top-level directory.
|
|
*
|
|
* Contributions after 2012-01-13 are licensed under the terms of the
|
|
* GNU GPL, version 2 or (at your option) any later version.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qapi/type-helpers.h"
|
|
#include "qemu/error-report.h"
|
|
#include "channel.h"
|
|
#include "exec.h"
|
|
#include "migration.h"
|
|
#include "io/channel-command.h"
|
|
#include "trace.h"
|
|
#include "qemu/cutils.h"
|
|
|
|
#ifdef WIN32
|
|
const char *exec_get_cmd_path(void)
|
|
{
|
|
g_autofree char *detected_path = g_new(char, MAX_PATH);
|
|
if (GetSystemDirectoryA(detected_path, MAX_PATH) == 0) {
|
|
warn_report("Could not detect cmd.exe path, using default.");
|
|
return "C:\\Windows\\System32\\cmd.exe";
|
|
}
|
|
pstrcat(detected_path, MAX_PATH, "\\cmd.exe");
|
|
return g_steal_pointer(&detected_path);
|
|
}
|
|
#endif
|
|
|
|
QIOChannel *exec_connect_outgoing(MigrationState *s, strList *command,
|
|
Error **errp)
|
|
{
|
|
QIOChannel *ioc = NULL;
|
|
g_auto(GStrv) argv = strv_from_str_list(command);
|
|
const char * const *args = (const char * const *) argv;
|
|
g_autofree char *new_command = g_strjoinv(" ", (char **)argv);
|
|
|
|
trace_migration_exec_outgoing(new_command);
|
|
ioc = QIO_CHANNEL(qio_channel_command_new_spawn(args, O_RDWR, errp));
|
|
if (!ioc) {
|
|
return NULL;
|
|
}
|
|
|
|
qio_channel_set_name(ioc, "migration-exec-outgoing");
|
|
return ioc;
|
|
}
|
|
|
|
static gboolean exec_accept_incoming_migration(QIOChannel *ioc,
|
|
GIOCondition condition,
|
|
gpointer opaque)
|
|
{
|
|
migration_channel_process_incoming(ioc);
|
|
object_unref(OBJECT(ioc));
|
|
return G_SOURCE_REMOVE;
|
|
}
|
|
|
|
void exec_connect_incoming(strList *command, Error **errp)
|
|
{
|
|
QIOChannel *ioc;
|
|
g_auto(GStrv) argv = strv_from_str_list(command);
|
|
const char * const *args = (const char * const *) argv;
|
|
g_autofree char *new_command = g_strjoinv(" ", (char **)argv);
|
|
|
|
trace_migration_exec_incoming(new_command);
|
|
ioc = QIO_CHANNEL(qio_channel_command_new_spawn(args, O_RDWR, errp));
|
|
if (!ioc) {
|
|
return;
|
|
}
|
|
|
|
qio_channel_set_name(ioc, "migration-exec-incoming");
|
|
qio_channel_add_watch_full(ioc, G_IO_IN,
|
|
exec_accept_incoming_migration,
|
|
NULL, NULL,
|
|
g_main_context_get_thread_default());
|
|
}
|