starred/qemu-qemu
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2026-07-08 17:46:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

contrib/plugins/uftrace: fix infinite stack unwind detection

Browse Source 
So far, we were detecting infinite stacks but not stopping unwinding
since break only exited inner loop.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Link: https://lore.kernel.org/qemu-devel/20260210201344.1403613-2-pierrick.bouvier@linaro.org
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
This commit is contained in:
Pierrick Bouvier
2026-02-10 12:13:41 -08:00
parent 4ed6a7f2fd
commit 0b356560e2
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
contrib/plugins/uftrace.c
View File

@@ -443,7 +443,7 @@ static void cpu_unwind_stack(Cpu *cpu, uint64_t frame_pointer, uint64_t pc)
/* check we don't have an infinite stack */
for (size_t i = 0; i < depth; ++i) {
if (frame_pointer == unwind[i].frame_pointer) {
break;
goto after_unwind;
}
}
CallstackEntry e = {.frame_pointer = frame_pointer, .pc = pc};
@@ -456,6 +456,7 @@ static void cpu_unwind_stack(Cpu *cpu, uint64_t frame_pointer, uint64_t pc)
} while (frame_pointer && pc && depth < UNWIND_STACK_MAX_DEPTH);
#undef UNWIND_STACK_MAX_DEPTH
after_unwind:
/* push it from bottom to top */
while (depth) {
callstack_push(cpu->cs, unwind[depth - 1]);