From a252e830ab7b11d4e5aa8247c6835ac1b8d7fd3a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Date: Wed, 15 Apr 2026 23:05:55 +0200 Subject: [PATCH] cocci: Do not initialize variable used by QSLIST_FOREACH macro MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The QSLIST_FOREACH() macro, defined in "qemu/queue.h", always assigns its iterator variable when entering the loop. Remove the pointless and possibly misleading assignment. Mechanical patch using the following coccinelle spatch: @@ type T; identifier e; iterator FOREACH_MACRO =~ ".*_FOREACH.*"; statement S; @@ - T *e = ...; + T *e; ... when != e FOREACH_MACRO(e, ...) S Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Message-Id: <20260415215539.92629-3-philmd@linaro.org> --- ebpf/ebpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ebpf/ebpf.c b/ebpf/ebpf.c index 2d73beb479..a8d441b02c 100644 --- a/ebpf/ebpf.c +++ b/ebpf/ebpf.c @@ -40,7 +40,7 @@ void ebpf_register_binary_data(int id, const void *data, size_t datalen) const void *ebpf_find_binary_by_id(int id, size_t *sz, Error **errp) { - struct ElfBinaryDataEntry *it = NULL; + struct ElfBinaryDataEntry *it; QSLIST_FOREACH(it, &ebpf_elf_obj_list, node) { if (id == it->id) { *sz = it->datalen;