From 7da1fba27e3275ab458fd53a2b647ec316f11ffd Mon Sep 17 00:00:00 2001 From: Peter Xu Date: Mon, 26 Jan 2026 16:36:13 -0500 Subject: [PATCH] migration: Drop explicit block activation in postcopy fail path Postcopy (in failure path) should share with precopy on disk reactivations. Explicit activiation should used to be fine even if called twice, but after 26f65c01ed ("migration: Do not try to start VM if disk activation fails") we may want to avoid it and always capture failure when reactivation happens (even if we do not expect the failure to happen). Remove this redundant call. Reviewed-by: Fabiano Rosas Acked-by: Stefan Hajnoczi Signed-off-by: Peter Xu Link: https://lore.kernel.org/qemu-devel/20260126213614.3815900-5-peterx@redhat.com Signed-off-by: Fabiano Rosas --- migration/migration.c | 1 - 1 file changed, 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index 8d1c294b47..a5b0561cbe 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -2643,7 +2643,6 @@ fail: if (ms->state != MIGRATION_STATUS_CANCELLING) { migrate_set_state(&ms->state, ms->state, MIGRATION_STATUS_FAILED); } - migration_block_activate(NULL); bql_unlock(); return -1; }