starred/qemu
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2026-07-08 17:46:10 +00:00
Code Issues 380 Packages Projects Releases Wiki Activity

cocci: Do not initialize variable used by RAMBLOCK_FOREACH* macro

Browse Source 
The RAMBLOCK_FOREACH_MIGRATABLE() macro, defined in
migration/ram.h, ends up calling QLIST_FOREACH_RCU()
which always assigns its iterator variable when entering
the loop. Remove the pointless and possibly misleading
assignment.

Mechanical patch using the following coccinelle spatch:

  @@
  type T;
  identifier e;
  iterator FOREACH_MACRO =~ ".*_FOREACH.*";
  statement S;
  @@
  -    T *e = ...;
  +    T *e;
       ... when != e
       FOREACH_MACRO(e, ...) S

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
Message-Id: <20260415215539.92629-6-philmd@linaro.org>
This commit is contained in:
Philippe Mathieu-Daudé
2026-04-15 23:14:55 +02:00
parent 29e182003b
commit 9873bef556
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
migration/dirtyrate.c
View File

@@ -485,7 +485,7 @@ static bool record_ramblock_hash_info(struct RamblockDirtyInfo **block_dinfo,
{ {
struct RamblockDirtyInfo *info = NULL; struct RamblockDirtyInfo *info = NULL;
struct RamblockDirtyInfo *dinfo = NULL; struct RamblockDirtyInfo *dinfo = NULL;
RAMBlock *block = NULL; RAMBlock *block;
int total_count = 0; int total_count = 0;
int index = 0; int index = 0;
bool ret = false; bool ret = false;
@@ -568,7 +568,7 @@ static bool compare_page_hash_info(struct RamblockDirtyInfo *info,
int block_count) int block_count)
{ {
struct RamblockDirtyInfo *block_dinfo = NULL; struct RamblockDirtyInfo *block_dinfo = NULL;
RAMBlock *block = NULL; RAMBlock *block;
RAMBLOCK_FOREACH_MIGRATABLE(block) { RAMBLOCK_FOREACH_MIGRATABLE(block) {
if (skip_sample_ramblock(block)) { if (skip_sample_ramblock(block)) {