starred/qemu
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2026-05-18 02:12:22 +00:00
Code Issues 380 Packages Projects Releases Wiki Activity

rust/hpet: Explicitly initialize complex fields in init()

Browse Source 
Explicitly initialize more fields which are complex structures.

For simple types (bool/u32/usize), they can be omitted since C has
already initialized memory to all zeros and this is the valid
initialization for those simple types.

Previously such complex fields (InterruptSource/BqlCell/BqlRefCell) were
not explicitly initialized in init() and it's fine, because simply
setting all memory to zero aligns with their default initialization
behavior. However, this behavior is not robust. When adding new complex
struct or modifying the initial values of existing structs, this default
behavior can easily be broken.

Thus, do explicit initialization for HPET to become a good example.

Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Link: https://lore.kernel.org/r/20251113051937.4017675-16-zhao1.liu@intel.com
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Zhao Liu
2025-11-13 13:19:30 +08:00
committed by Paolo Bonzini
parent e3b5a1190a
commit b7d1deefc3
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
rust/hw/timer/hpet/src/device.rs
View File

@@ -733,6 +733,18 @@ impl HPETState {
HPET_REG_SPACE_LEN,
);
// Only consider members with more complex structures. C has already
// initialized memory to all zeros - simple types (bool/u32/usize) can
// rely on this without explicit initialization.
uninit_field_mut!(*this, regs).write(Default::default());
uninit_field_mut!(*this, hpet_offset).write(Default::default());
// Set null_mut for now and post_init() will fill it.
uninit_field_mut!(*this, irqs).write(Default::default());
uninit_field_mut!(*this, rtc_irq_level).write(Default::default());
uninit_field_mut!(*this, pit_enabled).write(Default::default());
uninit_field_mut!(*this, num_timers_save).write(Default::default());
uninit_field_mut!(*this, hpet_id).write(Default::default());
Self::init_timers(&mut this);
}