starred/qemu
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2026-07-08 17:46:10 +00:00
Code Issues 380 Packages Projects Releases Wiki Activity

[PR #208] [CLOSED] Change bitwise OR to logical OR #241

New Issue
Open
opened 2026-01-31 21:30:24 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 21:30:24 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/qemu/qemu/pull/208
Author: @celine-lee
Created: 3/14/2022
Status: ❌ Closed

Base: master ← Head: patch-1

📝 Commits (1)

  • b8858d6 Change bitwise OR to logical OR

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 hw/net/rocker/rocker_of_dpa.c (+1 -1)

📄 Description

My team and I were looking through the QEMU source code and found this line (325) that we think should be re-written to use a logical OR for improved readability and efficiency while retaining semantics.

Readability - simply evaluate binary states on either side of the expression rather than N-bit states
Efficiency - logical OR enables short circuiting in C

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/qemu/qemu/pull/208 **Author:** [@celine-lee](https://github.com/celine-lee) **Created:** 3/14/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`b8858d6`](https://github.com/qemu/qemu/commit/b8858d6d73106b40090ab25dfa493f2f1ec67d9a) Change bitwise OR to logical OR ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `hw/net/rocker/rocker_of_dpa.c` (+1 -1) </details> ### 📄 Description My team and I were looking through the QEMU source code and found this line (325) that we think should be re-written to use a logical OR for improved readability and efficiency while retaining semantics. Readability - simply evaluate binary states on either side of the expression rather than N-bit states Efficiency - logical OR enables short circuiting in C --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 21:30:25 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/qemu#241
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?