starred/qemu
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2026-02-04 05:35:39 +00:00
Code Issues 380 Packages Projects Releases Wiki Activity

[PR #208] Change bitwise OR to logical OR #246

New Issue
Open
opened 2026-01-31 21:30:26 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 21:30:26 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/qemu/qemu/pull/208

State: closed
Merged: No

My team and I were looking through the QEMU source code and found this line (325) that we think should be re-written to use a logical OR for improved readability and efficiency while retaining semantics.

Readability - simply evaluate binary states on either side of the expression rather than N-bit states
Efficiency - logical OR enables short circuiting in C

**Original Pull Request:** https://github.com/qemu/qemu/pull/208 **State:** closed **Merged:** No --- My team and I were looking through the QEMU source code and found this line (325) that we think should be re-written to use a logical OR for improved readability and efficiency while retaining semantics. Readability - simply evaluate binary states on either side of the expression rather than N-bit states Efficiency - logical OR enables short circuiting in C
claunia added the pull-request label 2026-01-31 21:30:26 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/qemu#246
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?