starred/qemu
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2026-02-04 05:35:39 +00:00
Code Issues 380 Packages Projects Releases Wiki Activity

[PR #240] [CLOSED] chore: rename tricore_feature to is_tricore_feature_enabled #291

New Issue
Open
opened 2026-01-31 21:30:38 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 21:30:38 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/qemu/qemu/pull/240
Author: @chenrui333
Created: 7/6/2023
Status: ❌ Closed

Base: master ← Head: rename-tricore_feature

📝 Commits (1)

  • c502724 chore: rename tricore_feature to is_tricore_feature_enabled

📊 Changes

4 files changed (+9 additions, -9 deletions)

View changed files

📝 target/tricore/cpu.c (+4 -4)
📝 target/tricore/cpu.h (+1 -1)
📝 target/tricore/helper.c (+2 -2)
📝 target/tricore/op_helper.c (+2 -2)

📄 Description

While upgrading capstone to v5, there was some name clash with the tricore_feature in capstone (which was introduced in this PR), thus rename tricore_feature to is_tricore_feature_enabled.

Build error log is below


/opt/homebrew/Cellar/capstone/5.0/include/capstone/tricore.h:561:3: error: redefinition of 'tricore_feature' as different kind of symbol
} tricore_feature;
  ^
../target/tricore/cpu.h:261:19: note: previous definition is here
static inline int tricore_feature(CPUTriCoreState *env, int feature)
                  ^
1 error generated.

Let me know if that makes sense. Thanks!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/qemu/qemu/pull/240 **Author:** [@chenrui333](https://github.com/chenrui333) **Created:** 7/6/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `rename-tricore_feature` --- ### 📝 Commits (1) - [`c502724`](https://github.com/qemu/qemu/commit/c50272465a4eaba85afaf41e0c3340c7d3ffb894) chore: rename `tricore_feature` to `is_tricore_feature_enabled` ### 📊 Changes **4 files changed** (+9 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `target/tricore/cpu.c` (+4 -4) 📝 `target/tricore/cpu.h` (+1 -1) 📝 `target/tricore/helper.c` (+2 -2) 📝 `target/tricore/op_helper.c` (+2 -2) </details> ### 📄 Description While [upgrading capstone to v5](https://github.com/Homebrew/homebrew-core/pull/135948), there was some name clash with the tricore_feature in capstone (which was introduced in [this PR](https://github.com/capstone-engine/capstone/pull/1973)), thus rename `tricore_feature` to `is_tricore_feature_enabled`. Build error log is below ``` /opt/homebrew/Cellar/capstone/5.0/include/capstone/tricore.h:561:3: error: redefinition of 'tricore_feature' as different kind of symbol } tricore_feature; ^ ../target/tricore/cpu.h:261:19: note: previous definition is here static inline int tricore_feature(CPUTriCoreState *env, int feature) ^ 1 error generated. ``` Let me know if that makes sense. Thanks! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 21:30:38 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/qemu#291
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?