starred/qemu
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2026-02-03 21:29:17 +00:00
Code Issues 380 Packages Projects Releases Wiki Activity

[PR #240] chore: rename tricore_feature to is_tricore_feature_enabled #296

New Issue
Open
opened 2026-01-31 21:30:39 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 21:30:39 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/qemu/qemu/pull/240

State: closed
Merged: No

While upgrading capstone to v5, there was some name clash with the tricore_feature in capstone (which was introduced in this PR), thus rename tricore_feature to is_tricore_feature_enabled.

Build error log is below


/opt/homebrew/Cellar/capstone/5.0/include/capstone/tricore.h:561:3: error: redefinition of 'tricore_feature' as different kind of symbol
} tricore_feature;
  ^
../target/tricore/cpu.h:261:19: note: previous definition is here
static inline int tricore_feature(CPUTriCoreState *env, int feature)
                  ^
1 error generated.

Let me know if that makes sense. Thanks!

**Original Pull Request:** https://github.com/qemu/qemu/pull/240 **State:** closed **Merged:** No --- While [upgrading capstone to v5](https://github.com/Homebrew/homebrew-core/pull/135948), there was some name clash with the tricore_feature in capstone (which was introduced in [this PR](https://github.com/capstone-engine/capstone/pull/1973)), thus rename `tricore_feature` to `is_tricore_feature_enabled`. Build error log is below ``` /opt/homebrew/Cellar/capstone/5.0/include/capstone/tricore.h:561:3: error: redefinition of 'tricore_feature' as different kind of symbol } tricore_feature; ^ ../target/tricore/cpu.h:261:19: note: previous definition is here static inline int tricore_feature(CPUTriCoreState *env, int feature) ^ 1 error generated. ``` Let me know if that makes sense. Thanks!
claunia added the pull-request label 2026-01-31 21:30:39 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/qemu#296
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?