mirror of
https://github.com/qemu/qemu.git
synced 2026-11-06 03:44:49 +00:00
6ea787b258
Commit a8686a9b, which made serial a qdev property instead of relying on
-drive options, accidentally allowed specifying serial strings of
arbitraty length while the virtio-blk protocol can only communicate 20
characters to the guest. This means that a longer serial number on the
command line is silently truncated to 20 characters from the guest
perspective.
This is obviously bad behaviour. People are specifying longer serials in
practice and guests will see something different than what was
configured. Instead of silent truncation, this should be an error.
Deprecate the silent truncation for now as a first step towards making
it an error later.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20261029231001.194240-4-kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>