mirror of
https://github.com/qemu/qemu.git
synced 2026-02-04 05:35:39 +00:00
91fc6d8101
MicroBlaze CPU model has a "little-endian" property, pointing to the @endi internal field. Commitc36ec3a965("hw/microblaze: Explicit CPU endianness") took care of having all MicroBlaze boards with an explicit default endianness, so later commit415aae543e("target/microblaze: Consider endianness while translating code") could infer the endianness at runtime from the @endi field, and not a compile time via the TARGET_BIG_ENDIAN definition. Doing so, we forgot to make the endianness explicit on user emulation, so there all CPUs are started with the default "little-endian=off" value, leading to breaking support for little endian binaries: $ readelf -h ./hello-world-mbel ELF Header: Magic: 7f 45 4c 46 01 01 01 00 00 00 00 00 00 00 00 00 Class: ELF32 Data: 2's complement, little endian $ qemu-microblazeel ./hello-world-mbel qemu: uncaught target signal 11 (Segmentation fault) - core dumped Segmentation fault (core dumped) Fix by restoring the previous behavior of starting with the builtin endianness of the binary: $ qemu-microblazeel ./hello-world-mbel Hello World Cc: qemu-stable@nongnu.org Fixes:415aae543e("target/microblaze: Consider endianness while translating code") Reported-by: Edgar E. Iglesias <edgar.iglesias@gmail.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@amd.com> Message-Id: <20251006173350.17455-1-philmd@linaro.org>
26 lines
611 B
C
26 lines
611 B
C
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qemu.h"
|
|
#include "loader.h"
|
|
#include "target_elf.h"
|
|
|
|
|
|
const char *get_elf_cpu_model(uint32_t eflags)
|
|
{
|
|
return TARGET_BIG_ENDIAN ? "any,little-endian=off"
|
|
: "any,little-endian=on";
|
|
}
|
|
|
|
void elf_core_copy_regs(target_elf_gregset_t *r, const CPUMBState *env)
|
|
{
|
|
for (int i = 0; i < 32; i++) {
|
|
r->pt.r[i] = tswapal(env->regs[i]);
|
|
}
|
|
|
|
r->pt.pc = tswapal(env->pc);
|
|
r->pt.msr = tswapal(mb_cpu_read_msr(env));
|
|
r->pt.ear = tswapal(env->ear);
|
|
r->pt.esr = tswapal(env->esr);
|
|
}
|