Fiona Ebner ffdcd081f5 block: move drain outside of bdrv_root_attach_child() ...

This is part of resolving the deadlock mentioned in commit "block:
move draining out of bdrv_change_aio_context() and mark GRAPH_RDLOCK".

The function bdrv_root_attach_child() runs under the graph lock, so it
is not allowed to drain. It is called by:
1. blk_insert_bs(), where a drained section is introduced.
2. block_job_add_bdrv(), which holds the graph lock itself.

block_job_add_bdrv() is called by:
1. mirror_start_job()
2. stream_start()
3. commit_start()
4. backup_job_create()
5. block_job_create()
6. In the test_blockjob_common_drain_node() unit test

In all callers, a drained section is introduced.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20250530151125.955508-13-f.ebner@proxmox.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>

2025-06-04 18:16:34 +02:00

..

export

block/export: Add option to allow export of inactive nodes

2025-02-06 14:46:40 +01:00

monitor

nbd/server: Allow users to adjust handshake limit in QMP

2025-02-11 13:45:47 -06:00

accounting.c

include: Rename sysemu/ -> system/

2024-12-20 17:44:56 +01:00

aio_task.c

block: Remove unused aio_task_pool_empty

2024-09-30 10:53:18 +03:00

amend.c

block: Mark BlockDriver callbacks for amend job GRAPH_RDLOCK

2023-05-10 14:16:54 +02:00

backup.c

block: move drain outside of bdrv_root_attach_child()

2025-06-04 18:16:34 +02:00

blkdebug.c

block: Expand block status mode from bool to flags

2025-05-14 15:33:34 -05:00

blkio.c

include/system: Move exec/memory.h to system/memory.h

2025-04-23 14:08:21 -07:00

blklogwrites.c

qapi: Move include/qapi/qmp/ to include/qobject/

2025-02-10 15:33:16 +01:00

blkreplay.c

include: Rename sysemu/ -> system/

2024-12-20 17:44:56 +01:00

blkverify.c

qapi: Move include/qapi/qmp/ to include/qobject/

2025-02-10 15:33:16 +01:00

block-backend.c

block: move drain outside of bdrv_root_attach_child()

2025-06-04 18:16:34 +02:00

block-copy.c

include: Rename sysemu/ -> system/

2024-12-20 17:44:56 +01:00

block-gen.h

block-coroutine-wrapper.py: support also basic return types

2022-12-15 16:07:43 +01:00

block-ram-registrar.c

include: Rename sysemu/ -> system/

2024-12-20 17:44:56 +01:00

bochs.c

block: Take graph lock for most of .bdrv_open

2023-11-08 17:56:18 +01:00

cloop.c

block: Take graph lock for most of .bdrv_open

2023-11-08 17:56:18 +01:00

commit.c

block: move drain outside of bdrv_root_attach_child()

2025-06-04 18:16:34 +02:00

copy-before-write.c

block: Expand block status mode from bool to flags

2025-05-14 15:33:34 -05:00

copy-before-write.h

blockdev-backup: Add error handling option for copy-before-write jobs

2025-05-12 18:19:31 +03:00

copy-on-read.c

qapi: Move include/qapi/qmp/ to include/qobject/

2025-02-10 15:33:16 +01:00

copy-on-read.h

block: Mark bdrv_(un)freeze_backing_chain() and callers GRAPH_RDLOCK

2023-11-07 19:14:19 +01:00

coroutines.h

block: Expand block status mode from bool to flags

2025-05-14 15:33:34 -05:00

create.c

qemu/compiler: Absorb 'clang-tsa.h'

2025-03-06 14:21:25 +01:00

crypto.c

include: Rename sysemu/ -> system/

2024-12-20 17:44:56 +01:00

crypto.h

block: Support detached LUKS header creation using qemu-img

2024-02-09 12:50:37 +00:00

curl.c

qapi: Move include/qapi/qmp/ to include/qobject/

2025-02-10 15:33:16 +01:00

dirty-bitmap.c

block: Mark bdrv_*_dirty_bitmap() and callers GRAPH_RDLOCK

2023-02-23 19:49:32 +01:00

dmg-bz2.c

…

dmg-lzfse.c

block/dmg: Ignore C99 prototype declaration mismatch from <lzfse.h>

2023-03-30 15:03:36 +02:00

dmg.c

block: Protect bs->file with graph_lock

2023-11-08 17:56:18 +01:00

dmg.h

block/dmg: Declare a type definition for DMG uncompress function

2023-04-24 13:53:44 -04:00

file-posix.c

file-posix: Probe paths and retry SG_IO on potential path errors

2025-05-22 17:56:50 +02:00

file-win32.c

qapi: Move include/qapi/qmp/ to include/qobject/

2025-02-10 15:33:16 +01:00

filter-compress.c

block: Take graph lock for most of .bdrv_open

2023-11-08 17:56:18 +01:00

gluster.c

file-posix, gluster: Handle zero block status hint better

2025-05-14 15:49:27 -05:00

graph-lock.c

graph-lock: remove AioContext locking

2023-12-21 22:49:27 +01:00

io_uring.c

file-posix: Support FUA writes

2025-03-13 17:44:55 +01:00

io.c

block: Add new bdrv_co_is_all_zeroes() function

2025-05-14 16:08:23 -05:00

iscsi-opts.c

modules: add block module annotations

2021-07-09 18:20:27 +02:00

iscsi.c

block: Expand block status mode from bool to flags

2025-05-14 15:33:34 -05:00

linux-aio.c

file-posix: Support FUA writes

2025-03-13 17:44:55 +01:00

meson.build

include: Rename sysemu/ -> system/

2024-12-20 17:44:56 +01:00

mirror.c

block: move drain outside of bdrv_root_attach_child()

2025-06-04 18:16:34 +02:00

nbd.c

block: Expand block status mode from bool to flags

2025-05-14 15:33:34 -05:00

nfs.c

qapi: Move include/qapi/qmp/ to include/qobject/

2025-02-10 15:33:16 +01:00

null.c

block: Expand block status mode from bool to flags

2025-05-14 15:33:34 -05:00

nvme.c

block/nvme: Use host PCI MMIO API

2025-05-08 10:21:10 -04:00

parallels-ext.c

qapi/crypto: Rename QCryptoHashAlgorithm to *Algo, and drop prefix

2024-09-10 14:02:16 +02:00

parallels.c

block: Expand block status mode from bool to flags

2025-05-14 15:33:34 -05:00

parallels.h

block: Protect bs->file with graph_lock

2023-11-08 17:56:18 +01:00

preallocate.c

block: Protect bs->file with graph_lock

2023-11-08 17:56:18 +01:00

progress_meter.c

coroutine: Clean up superfluous inclusion of qemu/lockable.h

2023-01-19 10:18:28 +01:00

qapi-system.c

qapi: Move include/qapi/qmp/ to include/qobject/

2025-02-10 15:33:16 +01:00

qapi.c

Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into staging

2025-02-10 13:25:36 -05:00

qcow2-bitmap.c

block/qcow2-bitmap: Replace g_memdup() by g_memdup2()

2024-05-08 19:11:34 +02:00

qcow2-cache.c

qcow2: Mark qcow2_signal_corruption() and callers GRAPH_RDLOCK

2023-10-12 16:31:33 +02:00

qcow2-cluster.c

qcow2: Take locks for accessing bs->file

2023-11-08 17:56:17 +01:00

qcow2-refcount.c

qcow2: Mark qcow2_signal_corruption() and callers GRAPH_RDLOCK

2023-10-12 16:31:33 +02:00

qcow2-snapshot.c

include: Rename sysemu/ -> system/

2024-12-20 17:44:56 +01:00

qcow2-threads.c

thread-pool: avoid passing the pool parameter every time

2023-04-25 13:17:28 +02:00

qcow2.c

block: Expand block status mode from bool to flags

2025-05-14 15:33:34 -05:00

qcow2.h

qcow2: Take locks for accessing bs->file

2023-11-08 17:56:17 +01:00

qcow.c

block: Expand block status mode from bool to flags

2025-05-14 15:33:34 -05:00

qed-check.c

qed: mark more functions as coroutine_fns and GRAPH_RDLOCK

2023-06-28 09:46:20 +02:00

qed-cluster.c

…

qed-l2-cache.c

osdep: Move memalign-related functions to their own header

2022-03-07 13:16:49 +00:00

qed-table.c

block: use bdrv_co_debug_event in coroutine context

2023-06-28 09:46:34 +02:00

qed.c

block: Expand block status mode from bool to flags

2025-05-14 15:33:34 -05:00

qed.h

block: Protect bs->file with graph_lock

2023-11-08 17:56:18 +01:00

quorum.c

block: Expand block status mode from bool to flags

2025-05-14 15:33:34 -05:00

raw-format.c

block: Expand block status mode from bool to flags

2025-05-14 15:33:34 -05:00

rbd.c

block: Expand block status mode from bool to flags

2025-05-14 15:33:34 -05:00

replication.c

blockdev-backup: Add error handling option for copy-before-write jobs

2025-05-12 18:19:31 +03:00

reqlist.c

block/reqlist: allow adding overlapping requests

2024-09-30 10:53:18 +03:00

snapshot-access.c

block: Expand block status mode from bool to flags

2025-05-14 15:33:34 -05:00

snapshot.c

block/snapshot: move drain outside of read-locked bdrv_snapshot_delete()

2025-06-04 18:16:33 +02:00

ssh.c

qapi: Move include/qapi/qmp/ to include/qobject/

2025-02-10 15:33:16 +01:00

stream.c

block: move drain outside of bdrv_root_attach_child()

2025-06-04 18:16:34 +02:00

throttle-groups.c

qom: Make InterfaceInfo[] uses const

2025-04-25 17:00:41 +02:00

throttle.c

block: Take graph lock for most of .bdrv_open

2023-11-08 17:56:18 +01:00

trace-events

nbd/client: Accept 64-bit block status chunks

2023-10-05 11:02:08 -05:00

trace.h

trace: switch position of headers to what Meson requires

2020-08-21 06:18:24 -04:00

vdi.c

block: Expand block status mode from bool to flags

2025-05-14 15:33:34 -05:00

vhdx-endian.c

…

vhdx-log.c

vhdx: Take locks for accessing bs->file

2023-11-08 17:56:18 +01:00

vhdx.c

qapi: Move include/qapi/qmp/ to include/qobject/

2025-02-10 15:33:16 +01:00

vhdx.h

vhdx: Take locks for accessing bs->file

2023-11-08 17:56:18 +01:00

vmdk.c

block: Expand block status mode from bool to flags

2025-05-14 15:33:34 -05:00

vpc.c

block: Expand block status mode from bool to flags

2025-05-14 15:33:34 -05:00

vvfat.c

block: Expand block status mode from bool to flags

2025-05-14 15:33:34 -05:00

win32-aio.c

aio: remove aio_disable_external() API

2023-05-30 17:37:26 +02:00

write-threshold.c

block: remove AioContext locking

2023-12-21 22:49:27 +01:00