starred/radzen-blazor
1
0
Fork 0
mirror of https://github.com/radzenhq/radzen-blazor.git synced 2026-02-04 05:35:44 +00:00
Code Issues 1.3k Packages Projects Releases 22 Wiki Activity

Pagination component defines colors that it does not use #1107

New Issue
Closed
opened 2026-01-29 17:49:01 +00:00 by claunia · 1 comment
claunia commented 2026-01-29 17:49:01 +00:00
Owner
Copy Link

Originally created by @djatkinsrealis on GitHub (Jan 30, 2024).

While styling a custom theme, I noticed that changing the hover colors, for the back and next buttons of the paginator, did not cause any visible change.

Looking at the themes\components\blazor_paginator.scss, these variables are defined but not used:

  • $paginator-back-button-hover-color
  • $paginator-next-button-hover-color
  • $paginator-back-button-hover-background-color
  • $paginator-next-button-hover-background-color

Instead, the back and next buttons use the standard pagination hover colors only.

I am happy to post a fix, but have 2 questions:

  • Do you intend to allow separate hover colors for the next and previous buttons (if not, should we just remove those unused variables).
  • Would you want to extend this to the first and last buttons as well (either share the above colors, or add new variables for those).
Originally created by @djatkinsrealis on GitHub (Jan 30, 2024). While styling a custom theme, I noticed that changing the hover colors, for the back and next buttons of the paginator, did not cause any visible change. Looking at the themes\components\blazor\_paginator.scss, these variables are defined but not used: - $paginator-back-button-hover-color - $paginator-next-button-hover-color - $paginator-back-button-hover-background-color - $paginator-next-button-hover-background-color Instead, the back and next buttons use the standard pagination hover colors only. I am happy to post a fix, but have 2 questions: - Do you intend to allow separate hover colors for the next and previous buttons (if not, should we just remove those unused variables). - Would you want to extend this to the first and last buttons as well (either share the above colors, or add new variables for those).
claunia commented 2026-01-29 17:49:02 +00:00
Author
Owner
Copy Link

@yordanov commented on GitHub (Jan 30, 2024):

Indeed, these were added in advance to make sure we cover differences between various design languages (e.g. Material buttons vs. Fluent vs. Radzen's defaults), but at the end of the day never utilised.

Do you need to define separate hover states for the non-numeric buttons in your theme? If there is no reasonable need to do so, we will consider removing them altogether with a next major version (v5). Just skip these in your theme for the time being.

Appreciate reporting such discrepancies. Thank you @djatkinsrealis 🙏

@yordanov commented on GitHub (Jan 30, 2024): Indeed, these were added in advance to make sure we cover differences between various design languages (e.g. Material buttons vs. Fluent vs. Radzen's defaults), but at the end of the day never utilised. Do you need to define separate hover states for the non-numeric buttons in your theme? If there is no reasonable need to do so, we will consider removing them altogether with a next major version (v5). Just skip these in your theme for the time being. Appreciate reporting such discrepancies. Thank you @djatkinsrealis 🙏
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
good first issue
pull-request
Mirrored from GitHub Pull Request
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/radzen-blazor#1107
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?