starred/radzen-blazor
1
0
Fork 0
mirror of https://github.com/radzenhq/radzen-blazor.git synced 2026-02-04 05:35:44 +00:00
Code Issues 1.3k Packages Projects Releases 22 Wiki Activity

Change visibility modifier for getSortIndex and SaveSettings in RadzenDataGrid #1294

New Issue
Open
opened 2026-01-29 17:51:44 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 17:51:44 +00:00
Owner
Copy Link

Originally created by @AlexForeach on GitHub (Jul 12, 2024).

I have implemented my own table inherited from RadzenDataGrid. When implementing the settings, I noticed that it is very inconvenient that the getSortIndex and SaveSettings methods are internal. I've looked at the source code, and it seems to me that it won't be worse if we make their visibility modifiers public.

I've already fixed it. If I am given access, I could send you a pull request.

Originally created by @AlexForeach on GitHub (Jul 12, 2024). I have implemented my own table inherited from RadzenDataGrid. When implementing the settings, I noticed that it is very inconvenient that the getSortIndex and SaveSettings methods are internal. I've looked at the source code, and it seems to me that it won't be worse if we make their visibility modifiers public. I've already fixed it. If I am given access, I could send you a pull request.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
good first issue
pull-request
Mirrored from GitHub Pull Request
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/radzen-blazor#1294
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?