starred/radzen-blazor
1
0
Fork 0
mirror of https://github.com/radzenhq/radzen-blazor.git synced 2026-02-04 05:35:44 +00:00
Code Issues 1.3k Packages Projects Releases 22 Wiki Activity

DataGridColumnPicking example problems #1547

New Issue
Closed
opened 2026-01-29 17:55:14 +00:00 by claunia · 1 comment
claunia commented 2026-01-29 17:55:14 +00:00
Owner
Copy Link

Originally created by @jakubiszon on GitHub (Dec 20, 2024).

There are numerous problems with this example:

  1. It shows two different methods to manage column visibility at the same time and thus is hard to understand.
  2. It needs to copy visibility settings in two places - inside the grid and in the example component. This part doesn't work - description below.
  3. There is a warning generated by the compiler.

Steps to reproduce

  1. Go to /datagrid-column-picker - it shows the DataGridColumnPicking.razor component.
  2. Deselect FirstName column using the default column picker
  3. Switch to context menu column picker and select the FirstName column using it
  4. The column will remain hidden

Desktop (please complete the following information):

  • OS: windows
  • Browser - chrome and firefox

I'd like to send a PR to fix it
I would propose to separate the default column picker and the one using context menus to two different examples, possibly placed on the same page. It will be much easier to understand this way. Would you accept a pull request if I submitted such solution?

Originally created by @jakubiszon on GitHub (Dec 20, 2024). There are numerous problems with this example: 1. It shows two different methods to manage column visibility at the same time and thus is hard to understand. 2. It needs to copy visibility settings in two places - inside the grid and in the example component. This part doesn't work - description below. 3. There is a warning generated by the compiler. **Steps to reproduce** 1. Go to [`/datagrid-column-picker`](https://blazor.radzen.com/datagrid-column-picker) - it shows the `DataGridColumnPicking.razor` component. 4. Deselect `FirstName` column using the default column picker 5. Switch to context menu column picker and select the `FirstName` column using it 6. The column will remain hidden **Desktop (please complete the following information):** - OS: windows - Browser - chrome and firefox **I'd like to send a PR to fix it** I would propose to separate the default column picker and the one using context menus to two different examples, possibly placed on the same page. It will be much easier to understand this way. Would you accept a pull request if I submitted such solution?
claunia commented 2026-01-29 17:55:15 +00:00
Author
Owner
Copy Link

@enchev commented on GitHub (Dec 25, 2024):

Sure @jakubiszon! We accept pull requests!

@enchev commented on GitHub (Dec 25, 2024): Sure @jakubiszon! We accept pull requests!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
good first issue
pull-request
Mirrored from GitHub Pull Request
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/radzen-blazor#1547
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?