starred/radzen-blazor
1
0
Fork 0
mirror of https://github.com/radzenhq/radzen-blazor.git synced 2026-02-04 05:35:44 +00:00
Code Issues 1.3k Packages Projects Releases 22 Wiki Activity

[PR #805] [CLOSED] Replacing the boolean autocomplete parameters with strings. #2327

New Issue
Open
opened 2026-01-29 18:18:18 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 18:18:18 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/radzenhq/radzen-blazor/pull/805
Author: @DaveBagler
Created: 2/9/2023
Status: ❌ Closed

Base: master ← Head: feature/autocomplete-string

📝 Commits (1)

  • 08937ef Replacing the boolean autocomplete parameters with strings.

📊 Changes

15 files changed (+118 additions, -29 deletions)

View changed files

📝 Radzen.Blazor.Tests/MaskTests.cs (+2 -2)
📝 Radzen.Blazor.Tests/NumericTests.cs (+2 -2)
📝 Radzen.Blazor.Tests/PasswordTests.cs (+2 -2)
📝 Radzen.Blazor.Tests/TextBoxTests.cs (+2 -2)
➕ Radzen.Blazor/AutoCompleteGuidance.cs (+82 -0)
📝 Radzen.Blazor/RadzenLogin.razor (+2 -2)
📝 Radzen.Blazor/RadzenLogin.razor.cs (+10 -3)
📝 Radzen.Blazor/RadzenMask.razor (+1 -1)
📝 Radzen.Blazor/RadzenMask.razor.cs (+3 -3)
📝 Radzen.Blazor/RadzenNumeric.razor (+1 -1)
📝 Radzen.Blazor/RadzenNumeric.razor.cs (+3 -3)
📝 Radzen.Blazor/RadzenPassword.razor (+1 -1)
📝 Radzen.Blazor/RadzenPassword.razor.cs (+3 -3)
📝 Radzen.Blazor/RadzenTextBox.razor (+1 -1)
📝 Radzen.Blazor/RadzenTextBox.razor.cs (+3 -3)

📄 Description

This pull request replaced the boolean AutoComplete parameter with a string AutoComplete parameter. This allows developers to use the auto-complete options supported by web browsers. See the available options on MDN and the spec.

This PR also adds a new static class that acts as an enum with each option linked to the appropriate attribute string value. It serves as a shortcut to avoid typos.

Also, the tests are updated to use the new string parameter while maintaining the same functionality.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/radzenhq/radzen-blazor/pull/805 **Author:** [@DaveBagler](https://github.com/DaveBagler) **Created:** 2/9/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feature/autocomplete-string` --- ### 📝 Commits (1) - [`08937ef`](https://github.com/radzenhq/radzen-blazor/commit/08937ef56e91918eb9fa767b22f66303f390a5ca) Replacing the boolean autocomplete parameters with strings. ### 📊 Changes **15 files changed** (+118 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `Radzen.Blazor.Tests/MaskTests.cs` (+2 -2) 📝 `Radzen.Blazor.Tests/NumericTests.cs` (+2 -2) 📝 `Radzen.Blazor.Tests/PasswordTests.cs` (+2 -2) 📝 `Radzen.Blazor.Tests/TextBoxTests.cs` (+2 -2) ➕ `Radzen.Blazor/AutoCompleteGuidance.cs` (+82 -0) 📝 `Radzen.Blazor/RadzenLogin.razor` (+2 -2) 📝 `Radzen.Blazor/RadzenLogin.razor.cs` (+10 -3) 📝 `Radzen.Blazor/RadzenMask.razor` (+1 -1) 📝 `Radzen.Blazor/RadzenMask.razor.cs` (+3 -3) 📝 `Radzen.Blazor/RadzenNumeric.razor` (+1 -1) 📝 `Radzen.Blazor/RadzenNumeric.razor.cs` (+3 -3) 📝 `Radzen.Blazor/RadzenPassword.razor` (+1 -1) 📝 `Radzen.Blazor/RadzenPassword.razor.cs` (+3 -3) 📝 `Radzen.Blazor/RadzenTextBox.razor` (+1 -1) 📝 `Radzen.Blazor/RadzenTextBox.razor.cs` (+3 -3) </details> ### 📄 Description This pull request replaced the boolean **AutoComplete** parameter with a string **AutoComplete** parameter. This allows developers to use the auto-complete options supported by web browsers. See the available options on [MDN](https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete) and the [spec](https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#autofill). This PR also adds a new `static class` that acts as an `enum` with each option linked to the appropriate attribute string value. It serves as a shortcut to avoid typos. Also, the tests are updated to use the new string parameter while maintaining the same functionality. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 18:18:18 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
good first issue
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/radzen-blazor#2327
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?