starred/radzen-blazor
1
0
Fork 0
mirror of https://github.com/radzenhq/radzen-blazor.git synced 2026-02-04 05:35:44 +00:00
Code Issues 1.3k Packages Projects Releases 22 Wiki Activity

[PR #928] [MERGED] Add ReadOnly property to CheckBoxList and CheckBoxListItem #2405

New Issue
Open
opened 2026-01-29 18:18:41 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 18:18:41 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/radzenhq/radzen-blazor/pull/928
Author: @johanpolak
Created: 4/19/2023
Status: ✅ Merged
Merged: 4/20/2023
Merged by: @enchev

Base: master ← Head: master

📝 Commits (3)

  • fc2cc19 Add ReadOnly property to CheckBoxList and CheckBoxListItem
  • 2538676 Set tabindex for CheckBox to -1 if ReadOnly
  • 7509a91 Add disabled and read-only property for checkboxlist populated from data

📊 Changes

4 files changed (+57 additions, -11 deletions)

View changed files

📝 Radzen.Blazor/RadzenCheckBox.razor (+1 -1)
📝 Radzen.Blazor/RadzenCheckBoxList.razor (+3 -3)
📝 Radzen.Blazor/RadzenCheckBoxList.razor.cs (+35 -7)
📝 Radzen.Blazor/RadzenCheckBoxListItem.cs (+18 -0)

📄 Description

Here is my pull request which adds the ReadOnly property to the CheckBoxList and the CheckBoxListItem. Additionally I added a commit to set the tabindex of the single CheckBox to -1 if the CheckBox is ReadOnly.

I have a few remaining questions about this approach.

  1. Should the method 'SelectAll' ignore read-only and disabled checkboxes in the list?
  2. Should the method 'IsAllSelected' ignore read-only and disabled checkboxes in the list?
  3. How to handle CheckBoxListItems which are gerenated through the data-property. The CheckBoxList has parameters for the TextProperty and a ValueProperty, should we add similar properties for Disabled and ReadOnly?

I look forward to your reaction.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/radzenhq/radzen-blazor/pull/928 **Author:** [@johanpolak](https://github.com/johanpolak) **Created:** 4/19/2023 **Status:** ✅ Merged **Merged:** 4/20/2023 **Merged by:** [@enchev](https://github.com/enchev) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`fc2cc19`](https://github.com/radzenhq/radzen-blazor/commit/fc2cc1922bd0f0a98ab47e832741ba9d5659cb4c) Add ReadOnly property to CheckBoxList and CheckBoxListItem - [`2538676`](https://github.com/radzenhq/radzen-blazor/commit/25386760313efe7852fc92a5088356f4c878be16) Set tabindex for CheckBox to -1 if ReadOnly - [`7509a91`](https://github.com/radzenhq/radzen-blazor/commit/7509a91721e19005b57267d5339f1a86ba8be973) Add disabled and read-only property for checkboxlist populated from data ### 📊 Changes **4 files changed** (+57 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `Radzen.Blazor/RadzenCheckBox.razor` (+1 -1) 📝 `Radzen.Blazor/RadzenCheckBoxList.razor` (+3 -3) 📝 `Radzen.Blazor/RadzenCheckBoxList.razor.cs` (+35 -7) 📝 `Radzen.Blazor/RadzenCheckBoxListItem.cs` (+18 -0) </details> ### 📄 Description Here is my pull request which adds the ReadOnly property to the CheckBoxList and the CheckBoxListItem. Additionally I added a commit to set the tabindex of the single CheckBox to -1 if the CheckBox is ReadOnly. I have a few remaining questions about this approach. 1. Should the method 'SelectAll' ignore read-only and disabled checkboxes in the list? 2. Should the method 'IsAllSelected' ignore read-only and disabled checkboxes in the list? 3. How to handle CheckBoxListItems which are gerenated through the data-property. The CheckBoxList has parameters for the TextProperty and a ValueProperty, should we add similar properties for Disabled and ReadOnly? I look forward to your reaction. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 18:18:41 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
good first issue
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/radzen-blazor#2405
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?