starred/radzen-blazor
1
0
Fork 0
mirror of https://github.com/radzenhq/radzen-blazor.git synced 2026-02-04 05:35:44 +00:00
Code Issues 1.3k Packages Projects Releases 22 Wiki Activity

[PR #1397] [MERGED] fix: filter icon styl #2718

New Issue
Open
opened 2026-01-29 18:20:10 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 18:20:10 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/radzenhq/radzen-blazor/pull/1397
Author: @marekm294
Created: 2/28/2024
Status: ✅ Merged
Merged: 2/29/2024
Merged by: @enchev

Base: master ← Head: fix-filter-icon-style-for-custom-filter

📝 Commits (1)

📊 Changes

4 files changed (+36 additions, -26 deletions)

View changed files

📝 Radzen.Blazor/QueryableExtension.cs (+20 -18)
📝 Radzen.Blazor/RadzenDataGridColumn.razor.cs (+13 -0)
📝 Radzen.Blazor/RadzenDataGridFilterMenu.razor (+2 -4)
📝 Radzen.Blazor/RadzenDataGridHeaderCell.razor (+1 -4)

📄 Description

fix: Parameter which is not used for custom filter must be set to change icon to active. This is removed in this PR and filter icon is active whenever customFilterExpression is not null and FilterOperator == FilterOperator.Custom.

Code extracted to methods so it's easier to read (There's no change at logic.. Only chang is adding HasCustomFilter() to FilterIconStyle() and HasCustomFilter(). The rest may by reverted but I had to find the problem)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/radzenhq/radzen-blazor/pull/1397 **Author:** [@marekm294](https://github.com/marekm294) **Created:** 2/28/2024 **Status:** ✅ Merged **Merged:** 2/29/2024 **Merged by:** [@enchev](https://github.com/enchev) **Base:** `master` ← **Head:** `fix-filter-icon-style-for-custom-filter` --- ### 📝 Commits (1) - [`70f750b`](https://github.com/radzenhq/radzen-blazor/commit/70f750bc83af5ca807b60281b7dcc6360d6dfeea) fix: filter icon styl ### 📊 Changes **4 files changed** (+36 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `Radzen.Blazor/QueryableExtension.cs` (+20 -18) 📝 `Radzen.Blazor/RadzenDataGridColumn.razor.cs` (+13 -0) 📝 `Radzen.Blazor/RadzenDataGridFilterMenu.razor` (+2 -4) 📝 `Radzen.Blazor/RadzenDataGridHeaderCell.razor` (+1 -4) </details> ### 📄 Description fix: Parameter which is not used for custom filter must be set to change icon to active. This is removed in this PR and filter icon is active whenever customFilterExpression is not null and FilterOperator == FilterOperator.Custom. Code extracted to methods so it's easier to read (There's no change at logic.. Only chang is adding HasCustomFilter() to FilterIconStyle() and HasCustomFilter(). The rest may by reverted but I had to find the problem) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 18:20:10 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
good first issue
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/radzen-blazor#2718
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?