starred/radzen-blazor
1
0
Fork 0
mirror of https://github.com/radzenhq/radzen-blazor.git synced 2026-02-04 05:35:44 +00:00
Code Issues 1.3k Packages Projects Releases 22 Wiki Activity

[PR #1497] [MERGED] Custom filters on RadzenDataGridColumn not recognized #2764

New Issue
Open
opened 2026-01-29 18:20:23 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 18:20:23 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/radzenhq/radzen-blazor/pull/1497
Author: @paulo-rico
Created: 5/2/2024
Status: ✅ Merged
Merged: 5/3/2024
Merged by: @enchev

Base: master ← Head: master

📝 Commits (1)

  • cec0d39 Don't set filterOperator if Custom

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 Radzen.Blazor/RadzenDataGridColumn.razor.cs (+1 -1)

📄 Description

Couldn't get my system to recognize a Custom filtered column. Looks like this code

if (_filterPropertyType == typeof(string))
{
    SetFilterOperator(FilterOperator.Contains);
}

was setting the filterOperator to FilterOperator.Contains. This meant that GetFilterOperator would return FilterOperator.Contains instead of FilterOperator.Custom, thus resulting in HasCustomFilter returning false.

        internal bool HasCustomFilter()
        {
            return GetFilterOperator() == FilterOperator.Custom && GetCustomFilterExpression() != null;
        }

        public FilterOperator GetFilterOperator()
        {
            return filterOperator ?? FilterOperator;
        }

Regards

Paul

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/radzenhq/radzen-blazor/pull/1497 **Author:** [@paulo-rico](https://github.com/paulo-rico) **Created:** 5/2/2024 **Status:** ✅ Merged **Merged:** 5/3/2024 **Merged by:** [@enchev](https://github.com/enchev) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`cec0d39`](https://github.com/radzenhq/radzen-blazor/commit/cec0d3963a95a9684e047c86cd372f9b40b00c2e) Don't set filterOperator if Custom ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Radzen.Blazor/RadzenDataGridColumn.razor.cs` (+1 -1) </details> ### 📄 Description Couldn't get my system to recognize a Custom filtered column. Looks like this code ``` if (_filterPropertyType == typeof(string)) { SetFilterOperator(FilterOperator.Contains); } ``` was setting the `filterOperator` to `FilterOperator.Contains`. This meant that `GetFilterOperator` would return `FilterOperator.Contains` instead of `FilterOperator.Custom`, thus resulting in `HasCustomFilter` returning `false`. ``` internal bool HasCustomFilter() { return GetFilterOperator() == FilterOperator.Custom && GetCustomFilterExpression() != null; } public FilterOperator GetFilterOperator() { return filterOperator ?? FilterOperator; } ``` Regards Paul --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 18:20:23 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
good first issue
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/radzen-blazor#2764
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?