starred/radzen-blazor
1
0
Fork 0
mirror of https://github.com/radzenhq/radzen-blazor.git synced 2026-02-04 05:35:44 +00:00
Code Issues 1.3k Packages Projects Releases 22 Wiki Activity

[PR #1612] [CLOSED] Dialog drag implementation improvement #2837

New Issue
Open
opened 2026-01-29 18:20:41 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 18:20:41 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/radzenhq/radzen-blazor/pull/1612
Author: @JoeCawthorne
Created: 7/22/2024
Status: ❌ Closed

Base: master ← Head: dialogDragSpeedImprovement

📝 Commits (10+)

  • 17cbbf1 dialog made draggable through a javascript implementation.
  • 3a76936 Format changes removed.
  • 4bd7e61 Merge with main.
  • 8793f02 Event handler is now being removed on dailog close.
  • 87d8d19 Event handler removed on dialog close, and "draggable" and "showTitle" parameters passed using bools.
  • 8a7699b Merge with develop.
  • 07ad5fb Merge branch 'master' into dialogDragSpeedImprovement
  • 4e1f982 Update branch in GitHub.
  • 965c5ba Update GitHub
  • 28d9b22 Merge with master.

📊 Changes

2 files changed (+140 additions, -48 deletions)

View changed files

📝 Radzen.Blazor/Rendering/DialogContainer.razor (+41 -16)
📝 Radzen.Blazor/wwwroot/Radzen.Blazor.js (+99 -32)

📄 Description

Changes:

  • The dialog Drag action parameter is now being called when the dialog is dragging.
  • The start event listener is not being removed when the dialog is closed. This is because there is still a reference to the dialog element in the start function, at the time the dialog is closed. If there is still a reference to an element, its event listeners will not be removed when it is closed. Because of this I have added a function which removes the start event listener when the dialog is closed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/radzenhq/radzen-blazor/pull/1612 **Author:** [@JoeCawthorne](https://github.com/JoeCawthorne) **Created:** 7/22/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `dialogDragSpeedImprovement` --- ### 📝 Commits (10+) - [`17cbbf1`](https://github.com/radzenhq/radzen-blazor/commit/17cbbf1dd61e4f50d9e671ec48530062736561cf) dialog made draggable through a javascript implementation. - [`3a76936`](https://github.com/radzenhq/radzen-blazor/commit/3a76936daf664f0d3a20e4d2f9e31245f5e1b11c) Format changes removed. - [`4bd7e61`](https://github.com/radzenhq/radzen-blazor/commit/4bd7e618c5a761a8df61eda07aeac6971655c31f) Merge with main. - [`8793f02`](https://github.com/radzenhq/radzen-blazor/commit/8793f023a0f83bb7ab0be0d4906fbe8b2a7b44dc) Event handler is now being removed on dailog close. - [`87d8d19`](https://github.com/radzenhq/radzen-blazor/commit/87d8d19cbd924052d7fda200344387ed37c9b405) Event handler removed on dialog close, and "draggable" and "showTitle" parameters passed using bools. - [`8a7699b`](https://github.com/radzenhq/radzen-blazor/commit/8a7699b5c1d9c4068a2fd61463c08b391b6f55ef) Merge with develop. - [`07ad5fb`](https://github.com/radzenhq/radzen-blazor/commit/07ad5fb0b4e83ab7c49931eb0be7ca4c2f82b0db) Merge branch 'master' into dialogDragSpeedImprovement - [`4e1f982`](https://github.com/radzenhq/radzen-blazor/commit/4e1f982fb81023bd950b294326c08d7e816b6376) Update branch in GitHub. - [`965c5ba`](https://github.com/radzenhq/radzen-blazor/commit/965c5ba521ea86d6df428f0e18c456797f55debd) Update GitHub - [`28d9b22`](https://github.com/radzenhq/radzen-blazor/commit/28d9b224714bf2dd587721dfa5ca9425bcaed008) Merge with master. ### 📊 Changes **2 files changed** (+140 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `Radzen.Blazor/Rendering/DialogContainer.razor` (+41 -16) 📝 `Radzen.Blazor/wwwroot/Radzen.Blazor.js` (+99 -32) </details> ### 📄 Description Changes: - The dialog Drag action parameter is now being called when the dialog is dragging. - The start event listener is not being removed when the dialog is closed. This is because there is still a reference to the dialog element in the start function, at the time the dialog is closed. If there is still a reference to an element, its event listeners will not be removed when it is closed. Because of this I have added a function which removes the start event listener when the dialog is closed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 18:20:41 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
good first issue
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/radzen-blazor#2837
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?