starred/radzen-blazor
1
0
Fork 0
mirror of https://github.com/radzenhq/radzen-blazor.git synced 2026-02-04 05:35:44 +00:00
Code Issues 1.3k Packages Projects Releases 22 Wiki Activity

[PR #1953] [MERGED] Fix IsAllSelected InDropdownBase #2989

New Issue
Open
opened 2026-01-29 18:21:25 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 18:21:25 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/radzenhq/radzen-blazor/pull/1953
Author: @nielsNocore
Created: 2/7/2025
Status: ✅ Merged
Merged: 2/10/2025
Merged by: @enchev

Base: master ← Head: fixIsAllSelectedInDropdownBase

📝 Commits (1)

  • f55abd6 Fix IsAllSelectedInDropdown is correct when disabled items exists

📊 Changes

2 files changed (+61 additions, -9 deletions)

View changed files

📝 Radzen.Blazor.Tests/DropDownTests.cs (+55 -5)
📝 Radzen.Blazor/DropDownBase.cs (+6 -4)

📄 Description

Fix IsAllSelected In DropdownBase is correct when disabled items exists
Added a check in the dropdownBase to check if there are any items to select.
added unit tests for it.

Issue can easily occur in a picklist:

Screenshot 2025-02-07 141959

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/radzenhq/radzen-blazor/pull/1953 **Author:** [@nielsNocore](https://github.com/nielsNocore) **Created:** 2/7/2025 **Status:** ✅ Merged **Merged:** 2/10/2025 **Merged by:** [@enchev](https://github.com/enchev) **Base:** `master` ← **Head:** `fixIsAllSelectedInDropdownBase` --- ### 📝 Commits (1) - [`f55abd6`](https://github.com/radzenhq/radzen-blazor/commit/f55abd63c417f15e79817449177cf7f727d1c68b) Fix IsAllSelectedInDropdown is correct when disabled items exists ### 📊 Changes **2 files changed** (+61 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `Radzen.Blazor.Tests/DropDownTests.cs` (+55 -5) 📝 `Radzen.Blazor/DropDownBase.cs` (+6 -4) </details> ### 📄 Description Fix IsAllSelected In DropdownBase is correct when disabled items exists Added a check in the dropdownBase to check if there are any items to select. added unit tests for it. Issue can easily occur in a picklist: <img width="643" alt="Screenshot 2025-02-07 141959" src="https://github.com/user-attachments/assets/8372c10a-9f76-4705-aba1-0f1aec4ba411" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 18:21:25 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
good first issue
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/radzen-blazor#2989
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?