starred/radzen-blazor
1
0
Fork 0
mirror of https://github.com/radzenhq/radzen-blazor.git synced 2026-02-04 05:35:44 +00:00
Code Issues 1.3k Packages Projects Releases 22 Wiki Activity

[PR #1977] [MERGED] Fix OnSideClose being called on open #3001

New Issue
Open
opened 2026-01-29 18:21:28 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 18:21:28 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/radzenhq/radzen-blazor/pull/1977
Author: @sethcalebweeks
Created: 2/18/2025
Status: ✅ Merged
Merged: 2/18/2025
Merged by: @enchev

Base: master ← Head: master

📝 Commits (1)

  • e26a625 Fix OnSideClose being called on open

📊 Changes

2 files changed (+15 additions, -2 deletions)

View changed files

📝 Radzen.Blazor/DialogService.cs (+1 -1)
📝 RadzenBlazorDemos/Pages/DialogSide.razor (+14 -1)

📄 Description

  • Move invocation of OnSideClose to inside the if block that checks if the task is complete.
  • Add Console to example to demonstrate event handler

Closes #1976

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/radzenhq/radzen-blazor/pull/1977 **Author:** [@sethcalebweeks](https://github.com/sethcalebweeks) **Created:** 2/18/2025 **Status:** ✅ Merged **Merged:** 2/18/2025 **Merged by:** [@enchev](https://github.com/enchev) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`e26a625`](https://github.com/radzenhq/radzen-blazor/commit/e26a625e27b949d1e92a1ea880cf269839b195c2) Fix OnSideClose being called on open ### 📊 Changes **2 files changed** (+15 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Radzen.Blazor/DialogService.cs` (+1 -1) 📝 `RadzenBlazorDemos/Pages/DialogSide.razor` (+14 -1) </details> ### 📄 Description - Move invocation of OnSideClose to inside the if block that checks if the task is complete. - Add Console to example to demonstrate event handler Closes #1976 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 18:21:28 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
good first issue
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/radzen-blazor#3001
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?