starred/radzen-blazor
1
0
Fork 0
mirror of https://github.com/radzenhq/radzen-blazor.git synced 2026-02-04 05:35:44 +00:00
Code Issues 1.3k Packages Projects Releases 22 Wiki Activity

[PR #2048] [CLOSED] Returning DialogOptions when a dialog is closed. Event renaming & improvements. #3047

New Issue
Open
opened 2026-01-29 18:21:40 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 18:21:40 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/radzenhq/radzen-blazor/pull/2048
Author: @JvanderStad
Created: 3/21/2025
Status: ❌ Closed

Base: master ← Head: development/jeffrey/feat/dialog-improvements

📝 Commits (10+)

  • c9926d0 Add tagging system to dialog options and update events
  • e33ecfb fix: restore original padding
  • 4e84a23 fix: correct class modifier
  • 342c04d Refactor SideDialogOptions initialization and Tags handling
  • 867d421 fix: naming
  • 7d75475 feat: remove temp initializer
  • b221c8a fix: format
  • dfe764c fix: backwards compatible
  • 87be1c9 fix: temp release
  • 0d55c8d fix: undo different fix

📊 Changes

5 files changed (+114 additions, -59 deletions)

View changed files

📝 Radzen.Blazor/DialogService.cs (+63 -38)
➕ Radzen.Blazor/Interfaces/IHasTags.cs (+15 -0)
➕ Radzen.Blazor/Internal/ObsoleteReferences.cs (+16 -0)
📝 Radzen.Blazor/RadzenDialog.razor (+16 -18)
📝 Radzen.Blazor/Rendering/DialogContainer.razor (+4 -3)

📄 Description

This change enables returning DialogOptions when a dialog is closed.

  • An IHasTags interface was introduced to allow other objects with similar structure and naming to be extended in the future.
  • A new ObsoleteReferences class was added to standardize and track deprecated members across the codebase.

Event Renaming & Improvements

For consistency and improved context, the following events have been renamed and now include DialogOptions as a callback parameter:

  • OnClose → OnDialogClose
  • OnOpen → OnDialogOpen
  • OnRefresh → OnDialogRefresh

These changes align the naming and structure of dialog events with existing patterns like OnSideClose and OnSideOpen.

The original events have been marked as [Obsolete], with clear version tracking via ObsoleteReferences.Version_6_3_3.

These updates improve:

  • Consistency across components
  • Extensibility of the event system
  • Developer clarity and maintainability

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/radzenhq/radzen-blazor/pull/2048 **Author:** [@JvanderStad](https://github.com/JvanderStad) **Created:** 3/21/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `development/jeffrey/feat/dialog-improvements` --- ### 📝 Commits (10+) - [`c9926d0`](https://github.com/radzenhq/radzen-blazor/commit/c9926d0df840491409a5b004db0cad715922011a) Add tagging system to dialog options and update events - [`e33ecfb`](https://github.com/radzenhq/radzen-blazor/commit/e33ecfbd95be806f73745f5a7e6a2ae5c8d0af57) fix: restore original padding - [`4e84a23`](https://github.com/radzenhq/radzen-blazor/commit/4e84a239d7abc5d1839cf8a8b0c6729e61507874) fix: correct class modifier - [`342c04d`](https://github.com/radzenhq/radzen-blazor/commit/342c04d78e49eda1e9b4299fc6fac9702f8d0473) Refactor SideDialogOptions initialization and Tags handling - [`867d421`](https://github.com/radzenhq/radzen-blazor/commit/867d421937a4e423dee89cfa69a70584f41e9a97) fix: naming - [`7d75475`](https://github.com/radzenhq/radzen-blazor/commit/7d75475eafa03c46651e3f7001faa4ca69692b2c) feat: remove temp initializer - [`b221c8a`](https://github.com/radzenhq/radzen-blazor/commit/b221c8af845ce437e3f93ee3ddb24531e4321f92) fix: format - [`dfe764c`](https://github.com/radzenhq/radzen-blazor/commit/dfe764c12a085f9d6037ab1f63f148424dd6c10e) fix: backwards compatible - [`87be1c9`](https://github.com/radzenhq/radzen-blazor/commit/87be1c90e82a1d8d3394c56e8839eef32b8c21d4) fix: temp release - [`0d55c8d`](https://github.com/radzenhq/radzen-blazor/commit/0d55c8d1718ba97137e30df6596c5cbf4847f8f0) fix: undo different fix ### 📊 Changes **5 files changed** (+114 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `Radzen.Blazor/DialogService.cs` (+63 -38) ➕ `Radzen.Blazor/Interfaces/IHasTags.cs` (+15 -0) ➕ `Radzen.Blazor/Internal/ObsoleteReferences.cs` (+16 -0) 📝 `Radzen.Blazor/RadzenDialog.razor` (+16 -18) 📝 `Radzen.Blazor/Rendering/DialogContainer.razor` (+4 -3) </details> ### 📄 Description **This change enables returning `DialogOptions` when a dialog is closed.** - An `IHasTags` interface was introduced to allow other objects with similar structure and naming to be extended in the future. - A new `ObsoleteReferences` class was added to standardize and track deprecated members across the codebase. ### Event Renaming & Improvements For consistency and improved context, the following events have been renamed and now include `DialogOptions` as a callback parameter: - `OnClose` → `OnDialogClose` - `OnOpen` → `OnDialogOpen` - `OnRefresh` → `OnDialogRefresh` These changes align the naming and structure of dialog events with existing patterns like `OnSideClose` and `OnSideOpen`. The original events have been marked as `[Obsolete]`, with clear version tracking via `ObsoleteReferences.Version_6_3_3`. These updates improve: - Consistency across components - Extensibility of the event system - Developer clarity and maintainability --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 18:21:40 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
good first issue
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/radzen-blazor#3047
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?