[PR #2097] [MERGED] Fixing 1st column with sub-row expander visible not taking `column.Is… #3069

Open
opened 2026-01-29 18:21:46 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/radzenhq/radzen-blazor/pull/2097
Author: @osre77
Created: 4/17/2025
Status: Merged
Merged: 4/23/2025
Merged by: @enchev

Base: masterHead: master


📝 Commits (1)

  • 779f3d5 Fixing 1st column with sub-row expander visible not taking column.IsInEditMode callback into account for rendering edit template.

📊 Changes

1 file changed (+18 additions, -1 deletions)

View changed files

📝 Radzen.Blazor/RadzenDataGrid.razor (+18 -1)

📄 Description

…InEditMode` callback into account for rendering edit template.

This fixes the issue where when you do in-cell editing combined with expandable rows (like self-referencing hierarchy) then the column.IsInEditMode callback was not taken into account for deciding if the edit or normal template should be rendered.

image

I tested this by modifying the in-cell editing demo to use self-referencing hierarchy.
Without the fix the 1st column is then always in edit mode, even if you click on any other column for editing.

Here: https://github.com/osre77/radzen-blazor/blob/in-cell-editing-demo/RadzenBlazorDemos/Pages/DataGridInCellEdit.razor
is the variant of the in-cell editing demo (does not make sense logically and breaks if you expand beyond the 2nd level).
This branch also contains the fix.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/radzenhq/radzen-blazor/pull/2097 **Author:** [@osre77](https://github.com/osre77) **Created:** 4/17/2025 **Status:** ✅ Merged **Merged:** 4/23/2025 **Merged by:** [@enchev](https://github.com/enchev) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`779f3d5`](https://github.com/radzenhq/radzen-blazor/commit/779f3d5cb02c2f932f6fb31c89108ed8c184e65e) Fixing 1st column with sub-row expander visible not taking `column.IsInEditMode` callback into account for rendering edit template. ### 📊 Changes **1 file changed** (+18 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Radzen.Blazor/RadzenDataGrid.razor` (+18 -1) </details> ### 📄 Description …InEditMode` callback into account for rendering edit template. This fixes the issue where when you do in-cell editing combined with expandable rows (like self-referencing hierarchy) then the `column.IsInEditMode` callback was not taken into account for deciding if the edit or normal template should be rendered. ![image](https://github.com/user-attachments/assets/badc344d-5aeb-4e6c-8867-77e2041b9185) I tested this by modifying the in-cell editing demo to use self-referencing hierarchy. Without the fix the 1st column is then always in edit mode, even if you click on any other column for editing. Here: https://github.com/osre77/radzen-blazor/blob/in-cell-editing-demo/RadzenBlazorDemos/Pages/DataGridInCellEdit.razor is the variant of the in-cell editing demo (does not make sense logically and breaks if you expand beyond the 2nd level). This branch also contains the fix. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 18:21:46 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/radzen-blazor#3069