starred/radzen-blazor
1
0
Fork 0
mirror of https://github.com/radzenhq/radzen-blazor.git synced 2026-02-04 05:35:44 +00:00
Code Issues 1.3k Packages Projects Releases 22 Wiki Activity

[PR #2336] [MERGED] Cleanup code a little #3200

New Issue
Open
opened 2026-01-29 18:22:24 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 18:22:24 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/radzenhq/radzen-blazor/pull/2336
Author: @joriverm
Created: 10/31/2025
Status: ✅ Merged
Merged: 11/3/2025
Merged by: @akorchev

Base: master ← Head: refactor/cleanupWarnings

📝 Commits (2)

  • 9d1b12f TextArea/Box change tests extended
  • ebe0f5f Cleanup warnings about FieldIdentifier.FieldName not able to be null

📊 Changes

26 files changed (+110 additions, -103 deletions)

View changed files

📝 Radzen.Blazor.Tests/TextAreaTests.cs (+32 -7)
📝 Radzen.Blazor.Tests/TextBoxTests.cs (+32 -7)
📝 Radzen.Blazor/DropDownBase.cs (+3 -3)
📝 Radzen.Blazor/RadzenAutoComplete.razor.cs (+2 -2)
📝 Radzen.Blazor/RadzenCheckBox.razor.cs (+1 -1)
📝 Radzen.Blazor/RadzenCheckBoxList.razor.cs (+2 -2)
📝 Radzen.Blazor/RadzenColorPicker.razor.cs (+1 -4)
📝 Radzen.Blazor/RadzenCompareValidator.cs (+1 -1)
📝 Radzen.Blazor/RadzenDatePicker.razor.cs (+5 -17)
📝 Radzen.Blazor/RadzenDropDownDataGrid.razor.cs (+1 -1)
📝 Radzen.Blazor/RadzenFileInput.razor.cs (+2 -2)
📝 Radzen.Blazor/RadzenHtmlEditor.razor.cs (+1 -4)
📝 Radzen.Blazor/RadzenMask.razor.cs (+1 -1)
📝 Radzen.Blazor/RadzenNumeric.razor.cs (+2 -2)
📝 Radzen.Blazor/RadzenPassword.razor.cs (+1 -1)
📝 Radzen.Blazor/RadzenRadioButtonList.razor.cs (+1 -2)
📝 Radzen.Blazor/RadzenRating.razor.cs (+1 -1)
📝 Radzen.Blazor/RadzenSecurityCode.razor.cs (+1 -1)
📝 Radzen.Blazor/RadzenSelectBar.razor.cs (+1 -1)
📝 Radzen.Blazor/RadzenSlider.razor.cs (+2 -8)

...and 6 more files

📄 Description

These are some random warnings and messages i got in visual studio.

  • FieldIdentifier.FieldName is never null, its not nullable (if nullable is enabled) and it throws an argumentnullexception on null
  • a null eventcallback is generally not done. it is accepted, but will throw errors warnings. this is why EventCallback.Empty exists
  • extended TextArea/TextBox tests to test that the correct event was handled

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/radzenhq/radzen-blazor/pull/2336 **Author:** [@joriverm](https://github.com/joriverm) **Created:** 10/31/2025 **Status:** ✅ Merged **Merged:** 11/3/2025 **Merged by:** [@akorchev](https://github.com/akorchev) **Base:** `master` ← **Head:** `refactor/cleanupWarnings` --- ### 📝 Commits (2) - [`9d1b12f`](https://github.com/radzenhq/radzen-blazor/commit/9d1b12f64b229e7a1b043db7b9390d9eee1bc2ac) TextArea/Box change tests extended - [`ebe0f5f`](https://github.com/radzenhq/radzen-blazor/commit/ebe0f5fd6775dc6b84f255e8d5dcfe52d5b17ecd) Cleanup warnings about FieldIdentifier.FieldName not able to be null ### 📊 Changes **26 files changed** (+110 additions, -103 deletions) <details> <summary>View changed files</summary> 📝 `Radzen.Blazor.Tests/TextAreaTests.cs` (+32 -7) 📝 `Radzen.Blazor.Tests/TextBoxTests.cs` (+32 -7) 📝 `Radzen.Blazor/DropDownBase.cs` (+3 -3) 📝 `Radzen.Blazor/RadzenAutoComplete.razor.cs` (+2 -2) 📝 `Radzen.Blazor/RadzenCheckBox.razor.cs` (+1 -1) 📝 `Radzen.Blazor/RadzenCheckBoxList.razor.cs` (+2 -2) 📝 `Radzen.Blazor/RadzenColorPicker.razor.cs` (+1 -4) 📝 `Radzen.Blazor/RadzenCompareValidator.cs` (+1 -1) 📝 `Radzen.Blazor/RadzenDatePicker.razor.cs` (+5 -17) 📝 `Radzen.Blazor/RadzenDropDownDataGrid.razor.cs` (+1 -1) 📝 `Radzen.Blazor/RadzenFileInput.razor.cs` (+2 -2) 📝 `Radzen.Blazor/RadzenHtmlEditor.razor.cs` (+1 -4) 📝 `Radzen.Blazor/RadzenMask.razor.cs` (+1 -1) 📝 `Radzen.Blazor/RadzenNumeric.razor.cs` (+2 -2) 📝 `Radzen.Blazor/RadzenPassword.razor.cs` (+1 -1) 📝 `Radzen.Blazor/RadzenRadioButtonList.razor.cs` (+1 -2) 📝 `Radzen.Blazor/RadzenRating.razor.cs` (+1 -1) 📝 `Radzen.Blazor/RadzenSecurityCode.razor.cs` (+1 -1) 📝 `Radzen.Blazor/RadzenSelectBar.razor.cs` (+1 -1) 📝 `Radzen.Blazor/RadzenSlider.razor.cs` (+2 -8) _...and 6 more files_ </details> ### 📄 Description These are some random warnings and messages i got in visual studio. * FieldIdentifier.FieldName is never null, its not nullable (if nullable is enabled) and it throws an argumentnullexception on null * a null eventcallback is generally not done. it is accepted, but will throw ~~errors~~ warnings. this is why EventCallback.Empty exists * extended TextArea/TextBox tests to test that the correct event was handled --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 18:22:24 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
good first issue
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/radzen-blazor#3200
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?