starred/radzen-blazor
1
0
Fork 0
mirror of https://github.com/radzenhq/radzen-blazor.git synced 2026-02-04 05:35:44 +00:00
Code Issues 1.3k Packages Projects Releases 22 Wiki Activity

Resource Overhead #536

New Issue
Closed
opened 2026-01-29 17:38:53 +00:00 by claunia · 1 comment
claunia commented 2026-01-29 17:38:53 +00:00
Owner
Copy Link

Originally created by @Pingger on GitHub (Sep 9, 2022).

The following code does a Integer Division, because:
size is of type int
PageSizeis of type int? and if null or <= 0 is 10 (also int)
so dividing size by PageSize is a Integer Division which is per definition floored!
Casting it to a decimal is useless casting that has performance and memory overhead. Just to then use Math.Floor which changes literally nothing and uses additional performance AND then the code casts it back to an int...

And the worst of all: It makes the code less readable!

c3490ac819/Radzen.Blazor/RadzenPager.razor.cs (L236)

Originally created by @Pingger on GitHub (Sep 9, 2022). The following code does a Integer Division, because: `size` is of type `int` `PageSize`is of type `int?` and if `null` or `<= 0` is `10` (also `int`) so dividing `size` by `PageSize` is a Integer Division which is per definition floored! Casting it to a `decimal` is useless casting that has performance and memory overhead. Just to then use `Math.Floor` which changes literally nothing and uses additional performance AND then the code casts it back to an `int`... And the worst of all: It makes the code less readable! https://github.com/radzenhq/radzen-blazor/blob/c3490ac819024455bd8de8733f20158435c79ad7/Radzen.Blazor/RadzenPager.razor.cs#L236
claunia commented 2026-01-29 17:38:54 +00:00
Author
Owner
Copy Link

@enchev commented on GitHub (Sep 10, 2022):

Hey @Pingger

Not sure what is size, maybe you are referring skip, PageSize is int also not int?. Still, you are right, no idea how this code ended like this - it's fixed now.

@enchev commented on GitHub (Sep 10, 2022): Hey @Pingger Not sure what is size, maybe you are referring skip, PageSize is int also not int?. Still, you are right, no idea how this code ended like this - it's fixed now.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
good first issue
pull-request
Mirrored from GitHub Pull Request
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/radzen-blazor#536
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?