From 31fd8f46d8adec933987dcfaaba60bac60ef4c60 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 27 Nov 2025 17:31:13 +0000 Subject: [PATCH] Fix Windows-only test failure by removing multi-threading support for RAR archives RAR decompression uses a shared Unpack instance which is not thread-safe. Removed SupportsMultiThreading override from RarArchive and RarArchiveEntry classes. Also removed the RAR multi-threaded tests since RAR doesn't support parallel extraction. Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com> --- src/SharpCompress/Archives/Rar/RarArchive.cs | 1 - src/SharpCompress/Archives/Rar/RarArchiveEntry.cs | 2 -- tests/SharpCompress.Test/Rar/RarArchiveTests.cs | 9 --------- 3 files changed, 12 deletions(-) diff --git a/src/SharpCompress/Archives/Rar/RarArchive.cs b/src/SharpCompress/Archives/Rar/RarArchive.cs index e552515f..e0246687 100644 --- a/src/SharpCompress/Archives/Rar/RarArchive.cs +++ b/src/SharpCompress/Archives/Rar/RarArchive.cs @@ -89,7 +89,6 @@ public class RarArchive : AbstractArchive } public override bool IsSolid => Volumes.First().IsSolidArchive; - public override bool SupportsMultiThreading => !IsMultiVolume && !IsSolid; public virtual int MinVersion => Volumes.First().MinVersion; public virtual int MaxVersion => Volumes.First().MaxVersion; diff --git a/src/SharpCompress/Archives/Rar/RarArchiveEntry.cs b/src/SharpCompress/Archives/Rar/RarArchiveEntry.cs index 898b42ca..aaba6d1e 100644 --- a/src/SharpCompress/Archives/Rar/RarArchiveEntry.cs +++ b/src/SharpCompress/Archives/Rar/RarArchiveEntry.cs @@ -134,6 +134,4 @@ public class RarArchiveEntry : RarEntry, IArchiveEntry ); } } - - public override bool SupportsMultiThreading => Parts.Single().SupportsMultiThreading; } diff --git a/tests/SharpCompress.Test/Rar/RarArchiveTests.cs b/tests/SharpCompress.Test/Rar/RarArchiveTests.cs index 025205db..9970b15c 100644 --- a/tests/SharpCompress.Test/Rar/RarArchiveTests.cs +++ b/tests/SharpCompress.Test/Rar/RarArchiveTests.cs @@ -293,15 +293,9 @@ public class RarArchiveTests : ArchiveTests [Fact] public void Rar_ArchiveFileRead() => ArchiveFileRead("Rar.rar"); - [Fact] - public Task Rar_ArchiveFileRead_Multithreaded() => ArchiveFileRead_Multithreaded("Rar.rar"); - [Fact] public void Rar5_ArchiveFileRead() => ArchiveFileRead("Rar5.rar"); - [Fact] - public Task Rar5_ArchiveFileRead_Multithreaded() => ArchiveFileRead_Multithreaded("Rar5.rar"); - [Fact] public void Rar_ArchiveFileRead_HasDirectories() => DoRar_ArchiveFileRead_HasDirectories("Rar.rar"); @@ -366,9 +360,6 @@ public class RarArchiveTests : ArchiveTests [Fact] public void Rar2_ArchiveFileRead() => ArchiveFileRead("Rar2.rar"); - [Fact] - public Task Rar2_ArchiveFileRead_Multithreaded() => ArchiveFileRead_Multithreaded("Rar2.rar"); - [Fact] public void Rar15_ArchiveFileRead() {