From a1dfa3dfa3ec5ec27fb7aba643f194da4b571586 Mon Sep 17 00:00:00 2001 From: Adam Hathcock Date: Wed, 22 Oct 2025 10:21:22 +0100 Subject: [PATCH] xplat tests for path characters --- tests/SharpCompress.Test/UtilityTests.cs | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/tests/SharpCompress.Test/UtilityTests.cs b/tests/SharpCompress.Test/UtilityTests.cs index cfcef644..cbd57304 100644 --- a/tests/SharpCompress.Test/UtilityTests.cs +++ b/tests/SharpCompress.Test/UtilityTests.cs @@ -619,20 +619,31 @@ public class UtilityTests #region ReplaceInvalidFileNameChars Tests +#if WINDOWS [Theory] [InlineData("valid_filename.txt", "valid_filename.txt")] - [InlineData("filetest.txt", "filetest.txt")] - [InlineData("<>:\"|?*", "<>:\"|?*")] - public void ReplaceInvalidFileNameChars_ValidFileName_UnchangedReturned( - string fileName, - string expected - ) + [InlineData("filetest.txt", "file_name_test.txt")] + [InlineData("<>:\"|?*", "_______")] + public void ReplaceInvalidFileNameChars_Windows(string fileName, string expected) { var result = Utility.ReplaceInvalidFileNameChars(fileName); Assert.Equal(expected, result); } +#else + [Theory] + [InlineData("valid_filename.txt", "valid_filename.txt")] + [InlineData("filetest.txt", "filetest.txt")] + [InlineData("<>:\"|?*", "<>:\"|?*")] + public void ReplaceInvalidFileNameChars_NonWindows(string fileName, string expected) + { + var result = Utility.ReplaceInvalidFileNameChars(fileName); + + Assert.Equal(expected, result); + } +#endif + #endregion #region ToReadOnly Tests