From b442327e5fa3f7656c2fd7b5b4074b6b4b7f2958 Mon Sep 17 00:00:00 2001 From: Adam Hathcock Date: Sat, 10 Oct 2026 15:40:35 +0100 Subject: [PATCH] Allow partial reads in ACE signature detection --- .../Common/Ace/Headers/AceHeader.cs | 2 +- .../Ace/AceHeaderReadTests.cs | 21 +++++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 tests/SharpCompress.Test/Ace/AceHeaderReadTests.cs diff --git a/src/SharpCompress/Common/Ace/Headers/AceHeader.cs b/src/SharpCompress/Common/Ace/Headers/AceHeader.cs index 8d270558..ba0899a7 100644 --- a/src/SharpCompress/Common/Ace/Headers/AceHeader.cs +++ b/src/SharpCompress/Common/Ace/Headers/AceHeader.cs @@ -100,7 +100,7 @@ public abstract partial class AceHeader // First two bytes are typically 0x60 0xEA (signature bytes) // At offset 7, there should be "**ACE**" (7 bytes) var bytes = new byte[14]; - if (stream.Read(bytes, 0, 14) != 14) + if (!stream.ReadFully(bytes)) { return false; } diff --git a/tests/SharpCompress.Test/Ace/AceHeaderReadTests.cs b/tests/SharpCompress.Test/Ace/AceHeaderReadTests.cs new file mode 100644 index 00000000..c7007400 --- /dev/null +++ b/tests/SharpCompress.Test/Ace/AceHeaderReadTests.cs @@ -0,0 +1,21 @@ +using System.IO; +using System.Threading; +using System.Threading.Tasks; +using SharpCompress.Common.Ace.Headers; +using SharpCompress.Test.Mocks; +using Xunit; + +namespace SharpCompress.Test.Ace; + +public class AceHeaderReadTests +{ + [Fact] + public async Task Ace_Signature_Allows_Partial_Reads() + { + byte[] header = [0, 0, 0, 0, 0, 0, 0, 42, 42, 65, 67, 69, 42, 42]; + using var sync = new ShortReadStream(new MemoryStream(header)); + using var asyncInput = new ShortReadStream(new MemoryStream(header)); + Assert.True(AceHeader.IsArchive(sync)); + Assert.True(await AceHeader.IsArchiveAsync(asyncInput, CancellationToken.None)); + } +}