Matt Kotsenas
c2bf540057
Close verification streams in TestBase.CompareArchivesByPath
2018-07-11 12:12:30 -07:00
Matt Kotsenas
a35c66e166
Move RewindableStreamTest.cs to the Streams/ folder
2018-07-10 12:07:33 -07:00
Matt Kotsenas
084c5e2686
Rename StreamTests.cs --> LzmaStreamTests.cs
2018-07-10 12:07:32 -07:00
Matt Kotsenas
6ae715b153
Move the TestStream and ForwardOnlyStream to Mocks folder
...
Move the `TestStream` and `ForwardOnlyStream` to Mocks/ to separate them
from the test classes.
2018-07-10 12:07:32 -07:00
Adam Hathcock
9c8692806a
Merge pull request #403 from MattKotsenas/bugfix/parallel-tests
...
Fix and re-enable tests
2018-07-10 20:01:20 +01:00
Matt Kotsenas
2d87351d2a
Add tests back to AppVeyor
2018-07-10 11:52:00 -07:00
Matt Kotsenas
3114afde0e
Add workaround for in-use files
...
The `TestBase` is not always able to delete the scratch folder in
`Dispose()` because sometimes the files are still in use.
This problem appears to be leaked file handles (likely due to incorrect
handling of `IDisposable`). To avoid the problem for now, force a
garbage collection prior to deleting the scratch folder.
2018-07-10 11:49:38 -07:00
Matt Kotsenas
7b338511cc
Create unique scratch path per test
...
Tests fail in Visual Studio because they try to reuse the same scratch
working space, and each test is responsible for resetting the space. To
simplify the test code:
1. Make `TestBase` `IDisposable` and have it create the scratch space
2. Remove `ResetScratch()` as it is now handled by the base class
3. Add a unique ID to each scrach space folder to prevent collisions
2018-07-10 11:46:44 -07:00
Adam Hathcock
09c27681e1
Merge pull request #402 from a764578566/master
...
file search support linq Pattern
2018-07-10 13:21:09 +01:00
zhoujr
4ebc1f82b7
file search support linq Pattern
2018-07-10 19:58:59 +08:00
Adam Hathcock
4640ca497a
Merge pull request #400 from MattKotsenas/feature/avoid-exception-in-readerfactory
...
Avoid throwing NotSupportedException in ReaderFactory hot path
2018-07-10 08:47:13 +01:00
Matt Kotsenas
bebccaae28
Avoid throwing NotSupportedException in ReaderFactory hot path
...
`ReaderFactory.Open()` calls `ZipArchive.IsZipFile()` to determine if
the `Stream` is a zip archive, which calls into
`ZipHeaderFactory.ReadHeader()`, which throws a `NotSupportedException`
when the `Stream` is not a zip archive.
To be clear, this exception is caught and `IsZipFile()` returns `false`,
but when called in a hot-path, these exceptions can become expensive.
To address this issue, `ReadHeader` now returns `null` in the default
cause instead of throwing. All callsites were already checking for and
handling `null`, so no behavior changes.
2018-07-09 18:44:46 -07:00
Adam Hathcock
7ee53373c6
Remove tests as AppVeyor can’t handle them at the moment
2018-07-09 09:05:10 +01:00
Adam Hathcock
d577fe1ac6
Merge pull request #385 from twirpx/master
...
Fixed EFS flag handling
2018-07-09 08:48:34 +01:00
Adam Hathcock
9f976aaf78
Merge branch 'master' into master
2018-07-09 08:48:26 +01:00
Adam Hathcock
8a7d7e366f
Merge pull request #396 from andreas-eriksson/Rar5IsEncrypted
...
Correctly set IsEncrypted for entries in Rar5.
2018-07-09 08:48:12 +01:00
Adam Hathcock
540ab1c6fa
Merge branch 'master' into master
2018-07-09 08:47:32 +01:00
Adam Hathcock
6792afbdb1
Merge branch 'master' into Rar5IsEncrypted
2018-07-09 08:44:32 +01:00
Adam Hathcock
e5a7185671
Mark for 0.22
2018-07-09 08:42:45 +01:00
Adam Hathcock
cdaf453b2d
Update dependencies and tests to .NET Core 2.1
2018-07-09 08:39:37 +01:00
Andreas Eriksson
f9cc80e1de
Correctly set IsEncrypted for entries in Rar5.
2018-06-29 15:51:40 +02:00
Adam Hathcock
7beff9e83c
Merge pull request #395 from adamhathcock/zip-slip-readers
...
Zip slip for Readers
2018-06-28 11:56:44 +01:00
Adam Hathcock
8f49f1b6f8
Merge remote-tracking branch 'origin/master' into zip-slip-readers
2018-06-28 11:52:43 +01:00
Adam Hathcock
7e336a0247
Slip in new SDK
2018-06-28 11:51:17 +01:00
Adam Hathcock
e37e8bdadc
Move path handling for extraction to be common
...
Reader and Archive now share more extraction logic
2018-06-28 11:46:51 +01:00
Adam Hathcock
40bd61b16b
Merge pull request #389 from frankyjuang/patch-1
...
Fix comment
2018-06-08 08:59:52 +01:00
Juang, Yi-Lin
87fbb45099
Fix comment
2018-06-08 11:27:43 +08:00
twirpx
e822f9a95c
Tests fixed to use explicit use of 866 encoding because of usage file named in Russian in several tests
2018-05-30 22:17:27 +05:00
twirpx
8a5a9159e1
Fixed DirectoryEntryHeader Name/Comment decoding in case of EFS flags set
2018-05-30 21:47:31 +05:00
twirpx
73b3c6b419
Merge branch 'master' of https://github.com/adamhathcock/sharpcompress
2018-05-30 20:28:15 +05:00
Adam Hathcock
f9bd7ebdb0
Merge pull request #384 from MrJul/perf-readbyte
...
Implemented ReadByte/WriteByte on streams to improve performance
2018-05-28 09:21:28 +01:00
Julien Lebosquain
540618c062
Implemented ReadByte/WriteByte on streams to improve performance
2018-05-27 16:31:44 +02:00
Adam Hathcock
9e96dec8c9
Merge pull request #383 from itn3000/add-filename-encoding-example
...
add example for custom file encoding
2018-05-23 09:14:46 +01:00
itn3000
7b7af612ba
add example for custom file encoding
2018-05-23 09:46:36 +09:00
Adam Hathcock
3a747ba87e
Update USAGE with new stream handling
2018-05-16 08:51:33 +01:00
Adam Hathcock
87e57e3a9a
Mark for 0.21.1
2018-05-15 09:14:56 +01:00
Adam Hathcock
785d0dcebf
Merge pull request #381 from adamhathcock/issue-380
...
Allow forced encoding to override default encoding
2018-05-15 09:13:16 +01:00
Adam Hathcock
2314776f55
Also check for CustomDecoder
2018-05-15 08:28:11 +01:00
Adam Hathcock
473f5d8189
Make GetDecoder use GetEncoding for forced
2018-05-14 16:20:57 +01:00
Adam Hathcock
be971cb6f7
Allow forced encoding to override default encoding
2018-05-14 16:08:31 +01:00
Adam Hathcock
3f94c1a50d
Remove lingering uses of non disposing stream
2018-05-08 14:10:49 +01:00
Adam Hathcock
2919ec293a
mark for 0.21
2018-05-06 09:39:36 +01:00
Adam Hathcock
19d25152e5
Merge pull request #378 from adamhathcock/fix_crypto_namespace
...
Fix namespaces to not interfere with bouncy castle users
2018-05-06 09:20:17 +01:00
Adam Hathcock
747180203c
Rider isn’t quite good enough in refactoring
2018-05-06 09:12:18 +01:00
Adam Hathcock
9f89a0844d
Fix namespaces to not interfere with bouncy castle users
2018-05-06 09:09:45 +01:00
Adam Hathcock
c64282e915
more naming
2018-05-06 09:07:06 +01:00
Adam Hathcock
c44a80bab2
Merge remote-tracking branch 'origin/master'
2018-05-06 08:59:23 +01:00
Adam Hathcock
8dfc4a2ffb
more variable naming
2018-05-06 08:59:00 +01:00
Adam Hathcock
c341c626a5
variable naming clean up
2018-05-06 08:49:32 +01:00
Adam Hathcock
173a0fe659
Some naming clean up
2018-05-05 19:35:58 +01:00
