copilot-swe-agent[bot]
e93c631900
Fix solid RAR single-entry extraction nullref path
2026-07-02 11:22:12 +00:00
Adam Hathcock
117eaa8167
Merge remote-tracking branch 'origin/master' into adam/merge-release-to-master
...
# Conflicts:
# src/SharpCompress/Common/ExtractionMethods.Async.cs
# src/SharpCompress/Common/ExtractionMethods.cs
2026-05-06 10:11:30 +01:00
Adam Hathcock
fc096e1996
new tests
2026-04-28 08:48:30 +01:00
Adam Hathcock
5d14c96fb0
clean up seekable checks
2026-04-23 10:19:37 +01:00
Adam Hathcock
3ed94dd462
add seekable checks
2026-04-23 09:56:26 +01:00
copilot-swe-agent[bot]
5d75f8c36d
Fix ForExternalStream→ForFilePath for file-path overloads and update SymbolicLinkHandler remarks
...
Agent-Logs-Url: https://github.com/adamhathcock/sharpcompress/sessions/41bf7d12-f140-47cf-96f9-3620eeb0eb32
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com >
2026-04-21 13:11:31 +00:00
Adam Hathcock
6a402a3b50
use with methods
2026-04-21 11:04:14 +01:00
Adam Hathcock
4f1f32b508
Fix usages of ReaderOptions
2026-04-21 10:55:59 +01:00
Adam Hathcock
f34ed8bd94
first commit for conslidating publci api
2026-03-06 11:22:09 +00:00
Adam Hathcock
855d4b4ce2
Use more SC exceptions instead of generic ones
2026-02-16 12:40:07 +00:00
Adam Hathcock
4ab03c0093
fixed more
2026-02-16 09:27:06 +00:00
Adam Hathcock
5263f43c29
more nulls and a namespace folder fix
2026-02-13 15:01:12 +00:00
Adam Hathcock
cf0ad9b323
Merge remote-tracking branch 'origin/copilot/fix-rar-extraction-issues' into adam/cleanup-options
2026-02-09 17:30:50 +00:00
Adam Hathcock
04dd177f19
first pass of removing extraction options (folded into reader options)
2026-02-09 16:52:54 +00:00
Adam Hathcock
29197f2142
Update tests/SharpCompress.Test/Rar/RarArchiveTests.cs
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-02-09 09:10:59 +00:00
copilot-swe-agent[bot]
d5cab8172b
Address code review feedback: clarify file size comment
...
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com >
2026-02-08 12:54:11 +00:00
copilot-swe-agent[bot]
4084b347d4
Fix RAR extraction to preserve subdirectory structure
...
- Set default ExtractFullPath=true in WriteToDirectoryInternal methods
- Add test case with sample RAR archive containing subdirectories
- Tests verify files are extracted to correct subdirectories, not root
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com >
2026-02-08 12:52:25 +00:00
Adam Hathcock
642b8bddb8
fixed merge
2026-02-04 14:41:55 +00:00
Adam Hathcock
27f7221902
Merge remote-tracking branch 'origin/release' into adam/release-merge
...
# Conflicts:
# Directory.Packages.props
# build/packages.lock.json
# src/SharpCompress/Common/Zip/WinzipAesEncryptionData.cs
# src/SharpCompress/SharpCompress.csproj
# src/SharpCompress/packages.lock.json
# tests/SharpCompress.Performance/packages.lock.json
# tests/SharpCompress.Test/SharpCompress.Test.csproj
# tests/SharpCompress.Test/packages.lock.json
2026-02-04 14:35:40 +00:00
copilot-swe-agent[bot]
ad7e64ba43
Fix test to use correct RarArchive API - all RAR tests passing
...
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com >
2026-02-02 09:33:37 +00:00
copilot-swe-agent[bot]
8737b7a38e
Apply infinite loop fix to SourceStream.cs and add test case
...
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com >
2026-02-02 09:31:38 +00:00
Adam Hathcock
779fba5deb
finish the open refactor?
2026-01-15 12:06:54 +00:00
Adam Hathcock
7b76858ae1
refactoring naming again
2026-01-15 11:41:30 +00:00
copilot-swe-agent[bot]
41ed4c8186
Add negative test case for premature stream termination
...
Added Rar_StreamValidation_ThrowsOnTruncatedStream test that verifies InvalidOperationException IS thrown when a RAR stream ends prematurely (position < expected length). Created TruncatedStream mock to simulate corrupted/truncated RAR files. This test validates the exception condition (_position < Length) works correctly.
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com >
2026-01-04 11:47:57 +00:00
copilot-swe-agent[bot]
90a33ce6b0
Remove duplicate test that doesn't verify exception case
...
Removed Rar_StreamValidation_CorrectExceptionBehavior test as it duplicated the validation in Rar_StreamValidation_OnlyThrowsOnPrematureEnd without actually testing the exception case. The remaining test adequately validates that the fix works correctly across multiple RAR formats.
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com >
2026-01-04 11:36:25 +00:00
copilot-swe-agent[bot]
12574798e1
Update test to document exception behavior for RAR stream validation
...
Renamed and enhanced the test to better document the fix. Added second test (Rar_StreamValidation_CorrectExceptionBehavior) that explicitly validates the difference between old and new behavior. Tests verify that InvalidOperationException is only thrown when position < expected length (premature termination), not when position >= expected length (which can be valid for some RAR files).
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com >
2026-01-04 09:55:18 +00:00
copilot-swe-agent[bot]
83b11254db
Add test for InvalidOperationException fix in RAR extraction
...
Added Rar_ExtractionCompletesWithoutInvalidOperationException test that verifies RAR extraction completes successfully without throwing InvalidOperationException when reading streams to EOF. The test validates the fix works across RAR, RAR5, RAR4, and RAR2 formats by reading all entries completely and ensuring no exceptions are thrown.
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com >
2026-01-04 09:33:31 +00:00
HeroponRikIBestest
e0660e7775
Add tests
2025-12-02 09:55:24 -05:00
Adam Hathcock
e7417e35ba
Update dependencies and csharpier
2025-04-28 16:18:01 +01:00
Adam Hathcock
5bf3d6dc32
update csharpier
2025-01-14 09:07:40 +00:00
Adam Hathcock
94d1503c64
more clean up
2024-03-14 08:57:16 +00:00
Adam Hathcock
0299232cb5
just using rider to clean up
2024-03-14 08:37:17 +00:00
Lars Vahlenberg
6c157def4b
set empty string if password not set
2024-01-04 21:16:07 +01:00
Lars Vahlenberg
388bbe047e
Blake2 Archive test OK
2024-01-02 20:46:55 +01:00
Lars Vahlenberg
d678275dee
Implement RAR5 decryption
2023-12-16 02:53:09 +01:00
Adam Hathcock
16e8dd447b
update csharpier
2023-03-21 13:14:08 +00:00
Twan van Dongen
8748314b5b
Fixed support for RAR 1.5 (algo15) and added test archive for unit testing. Rar 1.5 archive created using DOS version, which only supports uppercase characters, thus resulting in amending base class with 'UseCaseInsensitiveToVerify' toggle.
2023-02-21 21:28:38 +01:00
Adam Hathcock
b01e97b168
more clean up
2022-12-20 15:20:49 +00:00
Adam Hathcock
7da10795a1
csharpier
2022-12-20 15:14:22 +00:00
Adam Hathcock
959bbdcf1b
big clean up
2022-12-20 15:06:44 +00:00
Adam Hathcock
970e31a1b1
cleanup and run csharpier
2022-12-20 13:45:47 +00:00
Adam Hathcock
d6ac9a0363
Fix build
2022-12-20 13:09:16 +00:00
Nanook
4eb1fe0b80
RarArchive has Min/MaxVersion. RarEntry has Volumne Indexes. GZ CRC fix.
2022-07-15 21:15:10 +01:00
Craig
e424094fdf
7z encrypted filename exception with no password matches rar behaviour.
2022-05-04 01:35:58 +01:00
Craig
61c01ce9b0
Properly integrated zip multivolume and split support.
2022-04-30 19:35:40 +01:00
Craig
910aa1c22e
Corrected the Crc exception as it was within a #DEBUG define
2022-04-27 14:12:00 +01:00
Craig
71c8f3129f
RarStream Position fix, it was returning the file size. 7Zip CrcCheckStream always failed. Added a Solid Rar entry CRC test.
2022-04-27 13:16:05 +01:00
Craig
ec1999f73d
Added Split archive support with unit tests. Added ArchiveFactory.IsArchive() and minor refactor.
2022-04-21 00:12:26 +01:00
Craig
dab157bb71
Rar2 fix with new unit tests that fail on previous build.
2022-02-15 16:24:22 +00:00
Adam Hathcock
5357bd07c7
Let dotnet format do it’s thing
2021-01-09 13:33:34 +00:00
