Commit Graph

7 Commits

Author SHA1 Message Date
catester
c48a47c9b2 Revert "Revert "Replaced NotImplementedException for streams""
This reverts commit abed9eb2c9.
2015-03-14 14:22:55 +02:00
catester
abed9eb2c9 Revert "Replaced NotImplementedException for streams"
This reverts commit 391663ac67.
2015-03-14 13:31:02 +02:00
catester
391663ac67 Replaced NotImplementedException for streams
Especially for streams, it is more appropriate to throw
NotSupportedException instead of NotImplementedException. Usually
consumers of streams expect NotSupportedException to handle errors.
There are other places that also use NotImplementedException but I
didn't examine them for now. I only modified stream classes in
SharpCompress.IO. For reference about this best practise, please see
these articles:
http://blogs.msdn.com/b/brada/archive/2004/07/29/201354.aspx

http://blogs.msdn.com/b/jaredpar/archive/2008/12/12/notimplementedexception-vs-notsupportedexception.aspx
2015-03-14 12:46:34 +02:00
Adam Hathcock
0ab103e1b1 Made streams Dispose resilient
Made streams resilient to dispose being called multiple times.  Removed
unused stream.
2013-05-28 19:29:54 +01:00
Adam Hathcock
fcf86b738e Resharper code cleanup 2013-04-28 12:32:55 +01:00
Adam Hathcock
e1b5156ea1 Performance change from https://github.com/simmotech/sharpcompress 2013-04-28 10:08:33 +01:00
Adam Hathcock
7ce4b7d076 Initial commit 2013-04-07 10:58:58 +01:00