Commit Graph

2896 Commits

Author SHA1 Message Date
copilot-swe-agent[bot]
698257de29 Fix async-only stream violations: defer sync writes to async paths in writers and compressors
Agent-Logs-Url: https://github.com/adamhathcock/sharpcompress/sessions/6e4dec7d-12cd-4044-9935-4d354b911d11

Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
2026-04-28 10:24:36 +00:00
Adam Hathcock
c629dc5903 format Unpack 2026-04-28 11:03:08 +01:00
copilot-swe-agent[bot]
01273b73aa Fix AsyncOnlyStream to throw on sync operations
Agent-Logs-Url: https://github.com/adamhathcock/sharpcompress/sessions/6e4dec7d-12cd-4044-9935-4d354b911d11

Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
2026-04-28 09:57:04 +00:00
copilot-swe-agent[bot]
2b7faac10a Initial plan 2026-04-28 09:33:58 +00:00
Adam Hathcock
4f41b6f793 review fix 2026-04-28 10:28:50 +01:00
Adam Hathcock
9156a75c56 pool arrays 2026-04-28 10:26:18 +01:00
Adam Hathcock
2c0a15e0f0 make async and sync the same 2026-04-28 09:39:23 +01:00
Adam Hathcock
0352740ea1 more async tests 2026-04-28 09:14:31 +01:00
Adam Hathcock
fc096e1996 new tests 2026-04-28 08:48:30 +01:00
Adam Hathcock
18fade571e made Char be a method to match async method 2026-04-28 08:39:54 +01:00
Adam Hathcock
896dfd6537 some AI changes 2026-04-28 08:32:44 +01:00
copilot-swe-agent[bot]
2d4d9c285a Fix sync methods called in async RAR unpacker paths (Unpack29Async, Unpack5Async)
Agent-Logs-Url: https://github.com/adamhathcock/sharpcompress/sessions/7f2fcb59-4a41-4b27-ab32-17afec510b5e

Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
2026-04-28 08:17:23 +01:00
Adam Hathcock
d961301907 Merge pull request #1299 from adamhathcock/copilot/add-archive-detection-utility 2026-04-27 18:03:00 +01:00
Adam Hathcock
472765b5e3 fix up overloads and usages 2026-04-27 17:17:31 +01:00
Adam Hathcock
aae3502a8b intermediate commit 2026-04-27 16:43:06 +01:00
Adam Hathcock
ac8203e957 add sync tests 2026-04-26 11:30:56 +01:00
Adam Hathcock
4fc08534c2 add detection test 2026-04-26 11:18:27 +01:00
Adam Hathcock
d2c06e95d6 Clean up and move detection to new file 2026-04-26 11:07:11 +01:00
copilot-swe-agent[bot]
f118935bb8 Consolidate archive detection into shared TryFindFactory helpers
Agent-Logs-Url: https://github.com/adamhathcock/sharpcompress/sessions/9c5bf06d-3e2f-4bb5-9130-f5b7cdd1d0a0

Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
2026-04-25 11:13:00 +00:00
copilot-swe-agent[bot]
6c59326628 Add ArchiveInformation record and GetArchiveInformation API for consolidated archive detection
Agent-Logs-Url: https://github.com/adamhathcock/sharpcompress/sessions/324eaee6-e733-4193-b619-6eb75b435ec2

Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
2026-04-25 08:47:12 +00:00
copilot-swe-agent[bot]
a176ffee20 initial plan
Agent-Logs-Url: https://github.com/adamhathcock/sharpcompress/sessions/324eaee6-e733-4193-b619-6eb75b435ec2

Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
2026-04-25 08:42:21 +00:00
copilot-swe-agent[bot]
76300b9c97 Initial plan 2026-04-25 08:38:36 +00:00
Adam Hathcock
50179007f4 Merge pull request #1297 from adamhathcock/adam/enforce-seekable
Enforce seekable, readable and writable on streams
2026-04-23 11:50:24 +01:00
Adam Hathcock
41432ab062 human fix 2026-04-23 11:43:10 +01:00
Adam Hathcock
c9a68593ea add writable checks 2026-04-23 11:19:09 +01:00
Adam Hathcock
5d14c96fb0 clean up seekable checks 2026-04-23 10:19:37 +01:00
Adam Hathcock
2bae46e28a add extension methods for checks 2026-04-23 10:11:54 +01:00
Adam Hathcock
be4b6cdd7f ignore opencode stuff 2026-04-23 09:56:53 +01:00
Adam Hathcock
3ed94dd462 add seekable checks 2026-04-23 09:56:26 +01:00
Adam Hathcock
d3ff2ebe0a Merge pull request #1295 from adamhathcock/adam/fix-opening
Fix usage of ReaderOptions and pre-defined values
2026-04-21 15:15:04 +01:00
copilot-swe-agent[bot]
f4935b042f Fix ReaderOptions preset usage for file-path overloads and stale SymbolicLinkHandler docs
Agent-Logs-Url: https://github.com/adamhathcock/sharpcompress/sessions/41bf7d12-f140-47cf-96f9-3620eeb0eb32

Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
2026-04-21 13:15:28 +00:00
copilot-swe-agent[bot]
5d75f8c36d Fix ForExternalStream→ForFilePath for file-path overloads and update SymbolicLinkHandler remarks
Agent-Logs-Url: https://github.com/adamhathcock/sharpcompress/sessions/41bf7d12-f140-47cf-96f9-3620eeb0eb32

Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
2026-04-21 13:11:31 +00:00
Adam Hathcock
d10b93242c clean up for other options 2026-04-21 11:10:53 +01:00
Adam Hathcock
6a402a3b50 use with methods 2026-04-21 11:04:14 +01:00
Adam Hathcock
1f699f3552 manual clean up 2026-04-21 10:59:01 +01:00
Adam Hathcock
4f1f32b508 Fix usages of ReaderOptions 2026-04-21 10:55:59 +01:00
Adam Hathcock
3af023a4a8 Use explicit helpers for leaving streams open or not. 2026-04-21 10:43:43 +01:00
Adam Hathcock
72b81b8609 Merge pull request #1293 from puk06/fix/leave-stream-open-default
fix: Change LeaveStreamOpen default from true to false
2026-04-21 10:37:59 +01:00
Puk06
d99b406e09 fix: change default reader options in OpenArchive method for FileInfo 2026-04-21 17:02:30 +09:00
Adam Hathcock
a026806b1c tightens up tests 2026-04-21 08:25:16 +01:00
ぷこるふ
a351b56737 Apply suggestions from code review
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-04-21 10:26:31 +09:00
ぷこるふ
6a7e0b2f10 Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-04-21 10:09:10 +09:00
ぷこるふ
f5e27faefc Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-04-21 09:48:34 +09:00
ぷこるふ
1bd7bf2169 Apply suggestions from code review
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-04-21 09:40:13 +09:00
ぷこるふ
8d193db721 Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-04-21 09:32:27 +09:00
Puk06
ea950457f5 fix(docs): clarify stream handling rules and ownership in AGENTS.md 2026-04-21 09:16:16 +09:00
Puk06
23840b7a0f fix(zip): stop overriding LeaveStreamOpen in OpenArchive 2026-04-21 09:15:56 +09:00
Puk06
37c0f5aec5 fix: Change LeaveStreamOpen default from true to false
As of v0.21, the library is documented to close wrapped streams by default.
However, the ReaderOptions.LeaveStreamOpen property defaulted to true, which
contradicted the documented behavior and caused file locks when deleting
archives after extraction.

Changes:
- Set LeaveStreamOpen = false as the default (consistent with v0.21 design)
- Updated ReaderOptions.cs with comprehensive documentation explaining:
  * File-based vs caller-provided stream handling
  * When to use LeaveStreamOpen = true
  * Usage examples for both scenarios
- Updated AGENTS.md Stream Handling Rules section with:
  * Clear explanation of default disposal behavior
  * Overload differences (file-based vs stream-based)
  * Guidance on using ForExternalStream preset

This ensures the implementation matches the documented behavior and prevents
unexpected file locking issues during archive deletion.

Fixes: File deletion failures after archive extraction
2026-04-20 22:32:36 +09:00
Adam Hathcock
2a62f4dfe2 Add global pax support to TarArchive 2026-04-20 08:26:11 +01:00
Adam Hathcock
823afd4fd5 fixed header format behavior 2026-04-20 07:58:29 +01:00