starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-04 05:25:00 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #385] Fixed EFS flag handling #1002

New Issue
Closed
opened 2026-01-29 22:18:33 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:18:33 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/adamhathcock/sharpcompress/pull/385

State: closed
Merged: Yes

Fixed ArchiveEncoding to use CP437 as default encoding and UTF8 in case when Language encoding flag (EFS) is set.

Fixed DirectoryEntryHeader Name/Comment decoding to use ArchiveEncoding's Forced/Default/CustomEncoder if EFS flag is not set.

Tests fixed to use explicit use of 866 encoding because of file named in Russian usage in several tests.

**Original Pull Request:** https://github.com/adamhathcock/sharpcompress/pull/385 **State:** closed **Merged:** Yes --- Fixed ArchiveEncoding to use CP437 as default encoding and UTF8 in case when Language encoding flag (EFS) is set. Fixed DirectoryEntryHeader Name/Comment decoding to use ArchiveEncoding's Forced/Default/CustomEncoder if EFS flag is not set. Tests fixed to use explicit use of 866 encoding because of file named in Russian usage in several tests.
claunia added the pull-request label 2026-01-29 22:18:33 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1002
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?