starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-09 13:34:58 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #396] [MERGED] Correctly set IsEncrypted for entries in Rar5. #1004

New Issue
Closed
opened 2026-01-29 22:18:34 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:18:34 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/396
Author: @andreas-eriksson
Created: 6/29/2018
Status: ✅ Merged
Merged: 7/9/2018
Merged by: @adamhathcock

Base: master ← Head: Rar5IsEncrypted

📝 Commits (2)

  • f9cc80e Correctly set IsEncrypted for entries in Rar5.
  • 6792afb Merge branch 'master' into Rar5IsEncrypted

📊 Changes

1 file changed (+18 additions, -15 deletions)

View changed files

📝 src/SharpCompress/Common/Rar/Headers/FileHeader.cs (+18 -15)

📄 Description

This will set IsEncrypted to false unless there is a file encryption header.
IsEncrypted is currently set to HasFlag(FileFlagsV4.PASSWORD) which is the same as HasFlag(FileFlagsV5.HAS_CRC32)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/396 **Author:** [@andreas-eriksson](https://github.com/andreas-eriksson) **Created:** 6/29/2018 **Status:** ✅ Merged **Merged:** 7/9/2018 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `Rar5IsEncrypted` --- ### 📝 Commits (2) - [`f9cc80e`](https://github.com/adamhathcock/sharpcompress/commit/f9cc80e1dec3b8dd62a0497e62895726f85a4106) Correctly set IsEncrypted for entries in Rar5. - [`6792afb`](https://github.com/adamhathcock/sharpcompress/commit/6792afbdb1b53e4a6041ee080b8d10a3e1e7f692) Merge branch 'master' into Rar5IsEncrypted ### 📊 Changes **1 file changed** (+18 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Common/Rar/Headers/FileHeader.cs` (+18 -15) </details> ### 📄 Description This will set IsEncrypted to false unless there is a file encryption header. IsEncrypted is currently set to HasFlag(FileFlagsV4.PASSWORD) which is the same as HasFlag(FileFlagsV5.HAS_CRC32) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:18:34 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1004
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?