starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #403] Fix and re-enable tests #1013

New Issue
Open
opened 2026-01-29 22:18:36 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:18:36 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/adamhathcock/sharpcompress/pull/403

State: closed
Merged: Yes

Fix two problems with the test harness

  1. Give each test its own unique scratch space to prevent conflicts between tests

As part of having a unique scratch space, we can remove the ResetScratch() method and make the tests simpler and more resilient.

  1. Avoid leaking file handles by forcing a garbage collection prior to cleanup for each test
**Original Pull Request:** https://github.com/adamhathcock/sharpcompress/pull/403 **State:** closed **Merged:** Yes --- Fix two problems with the test harness 1. Give each test its own unique scratch space to prevent conflicts between tests As part of having a unique scratch space, we can remove the `ResetScratch()` method and make the tests simpler and more resilient. 2. Avoid leaking file handles by forcing a garbage collection prior to cleanup for each test
claunia added the pull-request label 2026-01-29 22:18:36 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1013
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?