starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #417] Allow Flush on EntryStream #1022

New Issue
Open
opened 2026-01-29 22:18:40 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:18:40 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/adamhathcock/sharpcompress/pull/417

State: closed
Merged: Yes

I have a tar-file that contains another tar.gz-file that I want do extract using SharpCompress.
When I am iterating through the outer tar-file, and find the tar.gz-file I want to extract, I use a CryptoStream that calculates the SHA256-sum of the tar.gz-entry while I extract it (using the IReader extension WriteAllToDirectory)

This seems to work without issues, but somtimes (due to CryptoStreams internal implementation), the tar.gz EntryStream will throw a NotSupportedException when the CryptoStream is being Disposed, because it will sometimes call Flush() on the EntryStream (see here).

From what I can see there is no reason to not allow flushing the EntryStream, as there is nothing to flush. Microsoft also mentions in the Stream.Flush-documentation that read-only streams should implement Flush with an empty method.
This pull request fixes that, and also adds a test that "provokes" this issue (not sure if that is needed or wanted)

**Original Pull Request:** https://github.com/adamhathcock/sharpcompress/pull/417 **State:** closed **Merged:** Yes --- I have a `tar`-file that contains another `tar.gz`-file that I want do extract using SharpCompress. When I am iterating through the outer `tar`-file, and find the `tar.gz`-file I want to extract, I use a CryptoStream that calculates the SHA256-sum of the `tar.gz`-entry while I extract it (using the IReader extension WriteAllToDirectory) This seems to work without issues, but somtimes (due to CryptoStreams internal implementation), the `tar.gz` EntryStream will throw a `NotSupportedException` when the CryptoStream is being Disposed, because it will sometimes call `Flush()` on the EntryStream ([see here](https://referencesource.microsoft.com/#mscorlib/system/security/cryptography/cryptostream.cs,141)). From what I can see there is no reason to not allow flushing the EntryStream, as there is nothing to flush. Microsoft also mentions in the [Stream.Flush-documentation](https://docs.microsoft.com/en-us/dotnet/api/system.io.stream.flush?view=netframework-4.7.2#System_IO_Stream_Flush) that read-only streams should implement Flush with an empty method. This pull request fixes that, and also adds a test that "provokes" this issue (not sure if that is needed or wanted)
claunia added the pull-request label 2026-01-29 22:18:40 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1022
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?