starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #515] [MERGED] Enable nullable #1069

New Issue
Open
opened 2026-01-29 22:18:52 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:18:52 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/515
Author: @iamcarbon
Created: 5/24/2020
Status: ✅ Merged
Merged: 5/24/2020
Merged by: @adamhathcock

Base: master ← Head: master

📝 Commits (1)

📊 Changes

145 files changed (+547 additions, -460 deletions)

View changed files

📝 src/SharpCompress/Archives/AbstractArchive.cs (+15 -15)
📝 src/SharpCompress/Archives/ArchiveFactory.cs (+4 -4)
📝 src/SharpCompress/Archives/GZip/GZipArchive.cs (+3 -3)
📝 src/SharpCompress/Archives/GZip/GZipArchiveEntry.cs (+1 -1)
📝 src/SharpCompress/Archives/GZip/GZipWritableArchiveEntry.cs (+4 -2)
📝 src/SharpCompress/Archives/IArchiveEntryExtensions.cs (+4 -4)
📝 src/SharpCompress/Archives/IArchiveExtensions.cs (+1 -1)
📝 src/SharpCompress/Archives/Rar/FileInfoRarFilePart.cs (+2 -2)
📝 src/SharpCompress/Archives/Rar/RarArchive.cs (+5 -5)
📝 src/SharpCompress/Archives/Rar/RarArchiveVolumeFactory.cs (+4 -4)
📝 src/SharpCompress/Archives/Rar/SeekableFilePart.cs (+3 -3)
📝 src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs (+6 -4)
📝 src/SharpCompress/Archives/Tar/TarArchive.cs (+5 -5)
📝 src/SharpCompress/Archives/Tar/TarWritableArchiveEntry.cs (+4 -2)
📝 src/SharpCompress/Archives/Zip/ZipArchive.cs (+11 -9)
📝 src/SharpCompress/Archives/Zip/ZipArchiveEntry.cs (+2 -2)
📝 src/SharpCompress/Common/ArchiveEncoding.cs (+2 -2)
📝 src/SharpCompress/Common/CompressedBytesReadEventArgs.cs (+9 -3)
📝 src/SharpCompress/Common/Entry.cs (+3 -5)
📝 src/SharpCompress/Common/ExtractionMethods.cs (+7 -7)

...and 80 more files

📄 Description

This PR

  • Enables nullable
  • Replaces == null with is null
  • Seals a few internal classes
  • Remove a single allocation by creating a static byte array

Nullable is disabled in various classes with initialization patterns that don't work well with nullable until C# v9.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/515 **Author:** [@iamcarbon](https://github.com/iamcarbon) **Created:** 5/24/2020 **Status:** ✅ Merged **Merged:** 5/24/2020 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`5b6a1c9`](https://github.com/adamhathcock/sharpcompress/commit/5b6a1c97e38102b4b3de3406a5b12b58ddb80241) Enable nullable ### 📊 Changes **145 files changed** (+547 additions, -460 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Archives/AbstractArchive.cs` (+15 -15) 📝 `src/SharpCompress/Archives/ArchiveFactory.cs` (+4 -4) 📝 `src/SharpCompress/Archives/GZip/GZipArchive.cs` (+3 -3) 📝 `src/SharpCompress/Archives/GZip/GZipArchiveEntry.cs` (+1 -1) 📝 `src/SharpCompress/Archives/GZip/GZipWritableArchiveEntry.cs` (+4 -2) 📝 `src/SharpCompress/Archives/IArchiveEntryExtensions.cs` (+4 -4) 📝 `src/SharpCompress/Archives/IArchiveExtensions.cs` (+1 -1) 📝 `src/SharpCompress/Archives/Rar/FileInfoRarFilePart.cs` (+2 -2) 📝 `src/SharpCompress/Archives/Rar/RarArchive.cs` (+5 -5) 📝 `src/SharpCompress/Archives/Rar/RarArchiveVolumeFactory.cs` (+4 -4) 📝 `src/SharpCompress/Archives/Rar/SeekableFilePart.cs` (+3 -3) 📝 `src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs` (+6 -4) 📝 `src/SharpCompress/Archives/Tar/TarArchive.cs` (+5 -5) 📝 `src/SharpCompress/Archives/Tar/TarWritableArchiveEntry.cs` (+4 -2) 📝 `src/SharpCompress/Archives/Zip/ZipArchive.cs` (+11 -9) 📝 `src/SharpCompress/Archives/Zip/ZipArchiveEntry.cs` (+2 -2) 📝 `src/SharpCompress/Common/ArchiveEncoding.cs` (+2 -2) 📝 `src/SharpCompress/Common/CompressedBytesReadEventArgs.cs` (+9 -3) 📝 `src/SharpCompress/Common/Entry.cs` (+3 -5) 📝 `src/SharpCompress/Common/ExtractionMethods.cs` (+7 -7) _...and 80 more files_ </details> ### 📄 Description This PR - Enables nullable - Replaces == null with is null - Seals a few internal classes - Remove a single allocation by creating a static byte array Nullable is disabled in various classes with initialization patterns that don't work well with nullable until C# v9. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:18:52 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1069
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?